WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#15280 closed defect (bug) (fixed)

Move inconsistently named class.*.php files

Reported by: scribu Owned by: westi
Milestone: 3.1 Priority: normal
Severity: trivial Version:
Component: General Keywords:
Focuses: Cc:

Description

There are several files in wp-includes that have a 'class.' prefix instead of 'class-'.

Some of these are marked as being a part of BackPress, while others aren't (class.wp-xmlrpc-server.php).

I think they should all be consisntly named, regardless if they're included in BackPress or not.

Change History (13)

#1 @nacin
10 years ago

I don't mind the BackPress files being different, but a standard would be nice.

#2 @scribu
10 years ago

  • Keywords westi added

The WP_HTTP_IXR_Client, newly introduced in WP 3.1, for example, is also inconsistently named.

#3 @scribu
10 years ago

  • Cc westi added
  • Keywords westi removed

Oups... westi is not a keyword :)

#4 @westi
10 years ago

  • Owner set to westi
  • Status changed from new to accepted

Personally I prefer the BackPress way :-)
And we do need a standard.
I'm trying to justify which way is better.

#5 @scribu
10 years ago

If it improved the file order somehow, I would prefer it too, but it doesn't.

#6 @nacin
10 years ago

class- is more consistent with nearly every PHP file and PHP file prefix in core, and better because most files are already named that way. We also don't use functions., like BackPress. The more we move, the more annoying a routine svn blame becomes, and update-core $oldfiles grows for basically no good reasoning.

#7 @nacin
10 years ago

Any more file renames that involve wp-settings.php need to be done by someone who can then deploy the changes manually to wporg, to ensure we don't accidentally take very important bits down on subsequent deploy.

#8 @westi
10 years ago

Ok.

Don't rename old classes or ones from BackPress that isn't worth the hassle it could cause people.

New classes:

http://codex.wordpress.org/WordPress_Coding_Standards#Variables.2C_Functions.2C_File_Names.2C_and_Operators

Going to fix the ones I've introduced.

#9 @westi
10 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [16149]) Rename new classes to match our coding standards. Fixes #15280.

#10 @hakre
10 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I suggest to rename to leftover files which are still not properly named (old, unproperly named files) and place stub-file that do deprecated warnings for the oldy and faulty ones.

That will save backwards compability and us developers the hassle to differ.

Now as we have a standard (or don't we have a standard?).

#11 follow-up: @nacin
10 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

We have a standard. We've just chosen to leave the BackPress scripts in place.

#12 in reply to: ↑ 11 @hakre
10 years ago

Replying to nacin:

We have a standard. We've just chosen to leave the BackPress scripts in place.

I'm not a native english speaker, probably you must explain the term "Standard" to me :)


Related: #14921

#13 @hakre
10 years ago

Related: #10287

Note: See TracTickets for help on using tickets.