#15280 closed defect (bug) (fixed)
Move inconsistently named class.*.php files
Reported by: | scribu | Owned by: | westi |
---|---|---|---|
Milestone: | 3.1 | Priority: | normal |
Severity: | trivial | Version: | |
Component: | General | Keywords: | |
Focuses: | Cc: |
Description
There are several files in wp-includes that have a 'class.' prefix instead of 'class-'.
Some of these are marked as being a part of BackPress, while others aren't (class.wp-xmlrpc-server.php).
I think they should all be consisntly named, regardless if they're included in BackPress or not.
Change History (13)
#2
@
14 years ago
- Keywords westi added
The WP_HTTP_IXR_Client, newly introduced in WP 3.1, for example, is also inconsistently named.
#4
@
14 years ago
- Owner set to westi
- Status changed from new to accepted
Personally I prefer the BackPress way :-)
And we do need a standard.
I'm trying to justify which way is better.
#6
@
14 years ago
class- is more consistent with nearly every PHP file and PHP file prefix in core, and better because most files are already named that way. We also don't use functions.
, like BackPress. The more we move, the more annoying a routine svn blame becomes, and update-core $oldfiles grows for basically no good reasoning.
#7
@
14 years ago
Any more file renames that involve wp-settings.php need to be done by someone who can then deploy the changes manually to wporg, to ensure we don't accidentally take very important bits down on subsequent deploy.
#8
@
14 years ago
Ok.
Don't rename old classes or ones from BackPress that isn't worth the hassle it could cause people.
New classes:
Going to fix the ones I've introduced.
#10
@
14 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
I suggest to rename to leftover files which are still not properly named (old, unproperly named files) and place stub-file that do deprecated warnings for the oldy and faulty ones.
That will save backwards compability and us developers the hassle to differ.
Now as we have a standard (or don't we have a standard?).
#11
follow-up:
↓ 12
@
14 years ago
- Resolution set to fixed
- Status changed from reopened to closed
We have a standard. We've just chosen to leave the BackPress scripts in place.
I don't mind the BackPress files being different, but a standard would be nice.