Arin whois link is borked

[nacin]

​http://ws.arin.net/cgi-bin/whois.pl?queryinput=72.233.56.138

I am tempted to propose an api.wordpress.org service, that way these links will never break, but more importantly because arin.net is one of like 7 services based on global regions, and requesting an Asian IP through arin.net doesn't work.

An IP/geo lookup in core would be prohibitive, but if we still want to keep a link (beyond the IP), then we could do this.

On the other hand, IP addresses are becoming less meaningful. Should we just kill the link?

[nacin]

New link is in this format:
​http://whois.arin.net/rest/ip/72.233.56.138

[ocean90]

+1 for killing it, there are enough plugins for showing the geo.

[ozh]

correct arin link

[ozh]

Patch if it's not killed. At least let's not have a 404. But honestly I think this link as is is of very little interest.

I too would like a service on api.wordpress.org. Not about geo location (who cares & there are lots of plugins) but more likely something connected with akismet that would give useful information about the IP (something like a trust level, or if it has been reported as spam already, that stuff)

[westi]

For now we should drop the link I think.

I can't remember the last time I clicked it.

[ozh]

remove whois link

[nacin]

They've since added redirection for the old link.

Maybe wp.com happiness might have some insights? For a while there, it was broken, so I am wondering if any requests came in. Doubtful.

[nacin]

(In [16411]) Fix arin whois link. props ozh. @todo consider its removal. see #15281.

[markjaquith]

Consider its removal (or replacement) in 3.2

[chriscct7]

The issue with the link was fixed in [16411]. Did you want this to remain open for re-consideration of removal or closed?

[fierevere]

Its better to replace ARIN with something else, as they dont give response for not ARIN allocated space

[SergeyBiryukov]

Related: #30840

[dd32]

#30840 was marked as a duplicate.

[dd32]

Four years later:

• I'm in favour of killing the link
• If we must keep it, replace it with a w.org link perhaps?

It seems like a great plugin for the minority of people who would use it, and most WordPress users wouldn't need to know the details anyway.

[helen]

I'm for getting rid of the link.

[afercia]

Would suggest to re-consider this ticket for the next releases, especially now that WordPress ​non-English downloads surpassed English downloads. Discussed a bit on Slack Accessibility, the link in edit-comments has also some accessibility issues, it's really not clear what that link is for.

[joedolson]

Three cheers for killing the link. Easily doable via a plug-in for those who want it.

[joedolson]

New patch.

Patch removes the arin link from the comment email & from the edit comments form, and adds a new filter 'edit_comment_misc_actions' at the end of the misc actions container in edit-form-comment.

Quick question: what's the general policy on adding an @since parameter in docs in a patch with no specific release defined? I usually just go with the next release, and assume it'll be updated appropriately if it is actually used at some future point.

[joedolson]

Remove arin.net links from email and comment edit.

[DrewAPicture]

Replying to joedolson:

Quick question: what's the general policy on adding an @since parameter in docs in a patch with no specific release defined? I usually just go with the next release, and assume it'll be updated appropriately if it is actually used at some future point.

Some people just use the version for the current cycle, while I've seen others use @since x.x.x (placeholder). No real policy, it typically gets checked and changed by the committer when they review/commit the patch.

[rachelbaker]

Refreshed patch and removed Whois from wp_notify_moderator message

[wonderboymusic]

In 32929:

Remove the whois.arin.net link from wp_notify_postauthor() and wp_notify_moderator().
Also, remove from edit-form-comment.php and add a new filter: edit_comment_misc_actions.

Props ozh, joedolson, rachelbaker.
Fixes #15281.