WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 6 years ago

#15281 closed defect (bug) (fixed)

Arin whois link is borked

Reported by: nacin Owned by: wonderboymusic
Milestone: 4.3 Priority: lowest
Severity: normal Version:
Component: Comments Keywords: has-patch
Focuses: accessibility Cc:

Description

http://ws.arin.net/cgi-bin/whois.pl?queryinput=72.233.56.138

I am tempted to propose an api.wordpress.org service, that way these links will never break, but more importantly because arin.net is one of like 7 services based on global regions, and requesting an Asian IP through arin.net doesn't work.

An IP/geo lookup in core would be prohibitive, but if we still want to keep a link (beyond the IP), then we could do this.

On the other hand, IP addresses are becoming less meaningful. Should we just kill the link?

Attachments (4)

whois.diff (1.7 KB) - added by ozh 10 years ago.
correct arin link
whois-remove.diff (1.5 KB) - added by ozh 10 years ago.
remove whois link
15281.patch (2.2 KB) - added by joedolson 6 years ago.
Remove arin.net links from email and comment edit.
15281.2.patch (2.9 KB) - added by rachelbaker 6 years ago.
Refreshed patch and removed Whois from wp_notify_moderator message

Download all attachments as: .zip

Change History (27)

#2 @ocean90
10 years ago

+1 for killing it, there are enough plugins for showing the geo.

@ozh
10 years ago

correct arin link

#3 @ozh
10 years ago

  • Keywords has-patch added

Patch if it's not killed. At least let's not have a 404. But honestly I think this link as is is of very little interest.

I too would like a service on api.wordpress.org. Not about geo location (who cares & there are lots of plugins) but more likely something connected with akismet that would give useful information about the IP (something like a trust level, or if it has been reported as spam already, that stuff)

#4 @westi
10 years ago

For now we should drop the link I think.

I can't remember the last time I clicked it.

@ozh
10 years ago

remove whois link

#5 @nacin
10 years ago

  • Priority changed from normal to lowest

They've since added redirection for the old link.

Maybe wp.com happiness might have some insights? For a while there, it was broken, so I am wondering if any requests came in. Doubtful.

#6 @nacin
10 years ago

(In [16411]) Fix arin whois link. props ozh. @todo consider its removal. see #15281.

#7 @markjaquith
10 years ago

  • Milestone changed from 3.1 to Future Release

Consider its removal (or replacement) in 3.2

#8 @tfnab
10 years ago

  • Cc martinhh@… added

#9 @chriscct7
6 years ago

  • Keywords dev-feedback added; has-patch removed

The issue with the link was fixed in [16411]. Did you want this to remain open for re-consideration of removal or closed?

#10 @fierevere
6 years ago

Its better to replace ARIN with something else, as they dont give response for not ARIN allocated space

#12 @dd32
6 years ago

#30840 was marked as a duplicate.

#13 @dd32
6 years ago

Four years later:

  • I'm in favour of killing the link
  • If we must keep it, replace it with a w.org link perhaps?

It seems like a great plugin for the minority of people who would use it, and most WordPress users wouldn't need to know the details anyway.

#14 @helen
6 years ago

I'm for getting rid of the link.

#15 @afercia
6 years ago

Would suggest to re-consider this ticket for the next releases, especially now that WordPress non-English downloads surpassed English downloads. Discussed a bit on Slack Accessibility, the link in edit-comments has also some accessibility issues, it's really not clear what that link is for.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


6 years ago

#17 @joedolson
6 years ago

Three cheers for killing the link. Easily doable via a plug-in for those who want it.

#18 @helen
6 years ago

  • Component changed from Mail to Comments
  • Keywords needs-patch added; dev-feedback removed

#19 follow-up: @joedolson
6 years ago

  • Keywords has-patch added; needs-patch removed

New patch.

Patch removes the arin link from the comment email & from the edit comments form, and adds a new filter 'edit_comment_misc_actions' at the end of the misc actions container in edit-form-comment.

Quick question: what's the general policy on adding an @since parameter in docs in a patch with no specific release defined? I usually just go with the next release, and assume it'll be updated appropriately if it is actually used at some future point.

@joedolson
6 years ago

Remove arin.net links from email and comment edit.

#20 in reply to: ↑ 19 @DrewAPicture
6 years ago

Replying to joedolson:

Quick question: what's the general policy on adding an @since parameter in docs in a patch with no specific release defined? I usually just go with the next release, and assume it'll be updated appropriately if it is actually used at some future point.

Some people just use the version for the current cycle, while I've seen others use @since x.x.x (placeholder). No real policy, it typically gets checked and changed by the committer when they review/commit the patch.

@rachelbaker
6 years ago

Refreshed patch and removed Whois from wp_notify_moderator message

#21 @rachelbaker
6 years ago

  • Milestone changed from Future Release to 4.3

#22 @rachelbaker
6 years ago

  • Focuses accessibility added

#23 @wonderboymusic
6 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 32929:

Remove the whois.arin.net link from wp_notify_postauthor() and wp_notify_moderator().
Also, remove from edit-form-comment.php and add a new filter: edit_comment_misc_actions.

Props ozh, joedolson, rachelbaker.
Fixes #15281.

Note: See TracTickets for help on using tickets.