Theme names that consist only of numbers won't be listed on themes page

[ocean90]

Name a theme 1234 and then go to the manage themes page. There will be an empty space:
​http://grab.by/7cTI
In trunk there is $theme_names = array_keys( $themes ); in class-wp-themes-list-table.php. After array_keys() the name is int(0), before it's string(4) "1234".

I could reproduce it in 2.9 and 3.0 too.

[nacin]

Not a regression, so moving to future now.

[Utkarsh]

Attached patch changes preserve_keys parameter to be true in the array_splice call.

[r19]

i can not locate the file to patch "class-wp-themes-list-table.php" in a 3.0.x installation, but error still exisits.

[SergeyBiryukov]

Replying to r19:

i can not locate the file to patch "class-wp-themes-list-table.php" in a 3.0.x installation, but error still exisits.

15306.patch​ was for 3.1. Still seems to apply correctly and fixes the issue. Refreshed just in case.

[nacin]

In [19980]:

Preserve keys when splitting themes up for pagination. props Utkarsh. fixes #15306.

[nacin]

Multisite has some quirks here. Looking into it.

[ocean90]

15306.ms.patch​ does preserve the keys in get_allowed_themes().

See ​http://www.php.net/manual/de/function.array-merge.php#100240

[SergeyBiryukov]

class-wp-ms-themes-list-table.php has a similar array_slice() call. While it doesn't seem to make any difference there, we should probably preserve the keys as well for consistency.

[nacin]

We have an array_merge() somewhere in WP_Theme. Let's fix this.

[nacin]

In [20481]:

Add arrays together in WP_Theme::get_allowed() to preserve keys (theme names could be numeric). props ocean90, fixes #15306.