WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#15308 closed defect (bug) (fixed)

Miscellaneous Admin Bar Issues

Reported by: filosofo Owned by: filosofo
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: General Keywords: has-patch
Focuses: Cc:

Description

From the Nov 3 #wordpress-dev chat comments by Jane Wells:

  • there is a hover state for the right-facing arrow after gravatar
  • having the gravatar pont to the username seems weird, they are the same adin section maybe we should rethink that
  • the widths of the subs make it look wonky (wider/narrower than the mains)
  • we should probably change New Content label to just Add New, consistent with admin links in backend

Attachments (8)

misc-admin-bar-quirks.15308.diff (1.2 KB) - added by filosofo 3 years ago.
15308.patch (2.0 KB) - added by ocean90 3 years ago.
enhancement to filosofo's patch
t15308-admin-bar-update-count-text-shadow.diff (407 bytes) - added by demetris 3 years ago.
Removes text-shadow from update-count span on admin bar
t15308-admin-bar-updates-title-attribute.diff (893 bytes) - added by demetris 3 years ago.
attribute title spanning the whole Updates menu item
15308.clean.css.patch (11.9 KB) - added by ocean90 3 years ago.
15308.nicer.patch (13.6 KB) - added by ocean90 3 years ago.
15308.rtl.patch (6.0 KB) - added by ocean90 3 years ago.
15308.blogname.patch (1.3 KB) - added by ocean90 3 years ago.

Download all attachments as: .zip

Change History (37)

comment:1 filosofo3 years ago

  • Keywords has-patch added
  • Status changed from new to assigned

misc-admin-bar-quirks.15308.diff

  • removes the hover state for the right-facing arrow after gravatar
  • sets the width of child links to 160px, imitating the behavior of nav menus in Twenty Ten, as Jane suggested in last weeks' dev chat.
  • Changes "new content" to "add new."

It doesn't do anything about the gravatar pointing to the username, as complained about in the second bullet OP.

ocean903 years ago

enhancement to filosofo's patch

comment:2 ocean903 years ago

I added a patch with some small modifications.

comment:3 filosofo3 years ago

Maybe you could say what the differences are intended to do?

comment:4 ryan3 years ago

(In [16301]) Admin bar tweaks. Props filosofo. see #15308

comment:5 ryan3 years ago

(In [16302]) Admin bar tweaks. Props filosofo. see #15308

comment:6 markjaquith3 years ago

(In [16435]) Make admin bar update bubbles DARK text on LIGHT background, per janeforshort. see #15308

demetris3 years ago

Removes text-shadow from update-count span on admin bar

comment:7 demetris3 years ago

The update count appears blurry for me on Linux and on Windows.

The above patch removes text-shadow from the update-count span.

@markjaquith:

You did not adapt the hover colors. :-)

comment:8 nacin3 years ago

(In [16462]) Clean up logic when selecting post types for the admin bar content drop-down. see #15308.

comment:9 nacin3 years ago

I think that a post type should also be publicly_queryable to be listed in the Add New. Ryan agreed but I wanted to post here first.

Reasoning: It's not something viewable on the front end, so why should it be on the admin bar and thus accessible from the front end?

This affects my Log Deprecated Notices plugin, but I don't need this change as I use show_in_menu !== true. That said, the change does have decent reasoning.

comment:10 demetris3 years ago

I think the attribute title for available updates (x Plugin Updates, y Theme Updates) should encompass the whole Updates item, not just the count bubble.

I attach a patch to explain what I mean.

(If we do that, we will also have to reposition an ID, and also do some CSS tweaking as well.)

demetris3 years ago

attribute title spanning the whole Updates menu item

comment:11 nacin3 years ago

(In [16463]) Second half of [16462]. props duck_. see #15308.

comment:12 voyagerfan57613 years ago

  • Cc WordPress@… added

comment:13 ryan3 years ago

(In [16610]) Default Add New menu link to first post type in list. Avoids empty href issues. see #15308

comment:14 nacin3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [16790]) Don't show blurry text shadow in the admin bar count. props demetris, fixes #15308.

comment:15 nacin3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Ended up testing my own patch then committing that one, and it doesn't work due to a missing class. Fixing.

comment:16 nacin3 years ago

Also meant to re-open anyway.

comment:17 nacin3 years ago

Of course the commit hook would fail for this one.

[16791]

Admin bar styling improvements.

  • Ensure there isn't a text shadow for update and comment counts.
  • Hide zero count of pending comments via PHP, not CSS.
  • Show the update title attribute across the entire menu item, props demetris.
  • Let the CSS breathe a little.

comment:18 nacin3 years ago

(In [16795]) Close a quote. see #15308.

ocean903 years ago

comment:19 ocean903 years ago

I will start to clean up the Admin Bar CSS a little bit. One by one and 15308.clean.css.patch is the first one. It removes unused code and lets the CSS breathe more. ;-)

comment:20 nacin3 years ago

(In [16852]) Admin bar CSS cleaning. props ocean90, see #15308.

comment:21 ryan3 years ago

With [16852], the debug menu (from the debug-bar plugin) is no longer placed on the right after the search box. Perhaps the plugin needs an update.

http://plugins.svn.wordpress.org/debug-bar/trunk

comment:22 ryan3 years ago

Looks like the plugin makes us of the ab-sadmin class. The plugin needs an update.

comment:23 ryan3 years ago

Perhaps we need a generic ab-float-to-the-end type class that goes right for LTR and left for RTL.

ocean903 years ago

ocean903 years ago

comment:25 ocean903 years ago

15308.rtl.patch removes the search input value Search (repetition and seems like a remnant from wp.com) and improves RTL styling.

comment:26 nacin3 years ago

(In [16875]) More admin bar styling improvements. Includes RTL fixes. Don't show redundant 'search' value. props ocean90, see #15308.

ocean903 years ago

comment:27 ocean903 years ago

15308.blogname.patch: $blog->domain should be shorten too when $blog->blogname is empty, also revert back to 15 characters, my mistake.

comment:28 ocean903 years ago

A question:

if ( ! isset( $blog->visible ) || $blog->visible === true ) {

When will be $blog->visible true or false? On my install it's always undefined.

comment:29 nacin3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [16952]) Admin bar blogname handling improvements. Kill visible property vestige. props ocean90, fixes #15308.

Note: See TracTickets for help on using tickets.