Miscellaneous Admin Bar Issues

[filosofo]

From the Nov 3 #wordpress-dev chat comments by Jane Wells:

• there is a hover state for the right-facing arrow after gravatar
• having the gravatar pont to the username seems weird, they are the same adin section maybe we should rethink that
• the widths of the subs make it look wonky (wider/narrower than the mains)
• we should probably change New Content label to just Add New, consistent with admin links in backend

[filosofo]

misc-admin-bar-quirks.15308.diff

• removes the hover state for the right-facing arrow after gravatar
• sets the width of child links to 160px, imitating the behavior of nav menus in Twenty Ten, as Jane suggested in last weeks' dev chat.
• Changes "new content" to "add new."

It doesn't do anything about the gravatar pointing to the username, as complained about in the second bullet OP.

[ocean90]

enhancement to filosofo's patch

[ocean90]

I added a patch with some small modifications.

[filosofo]

Maybe you could say what the differences are intended to do?

[ryan]

(In [16301]) Admin bar tweaks. Props filosofo. see #15308

[ryan]

(In [16302]) Admin bar tweaks. Props filosofo. see #15308

[markjaquith]

(In [16435]) Make admin bar update bubbles DARK text on LIGHT background, per janeforshort. see #15308

[demetris]

Removes text-shadow from update-count span on admin bar

[demetris]

The update count appears blurry for me on Linux and on Windows.

The above patch removes text-shadow from the update-count span.

@markjaquith:

You did not adapt the hover colors. :-)

[nacin]

(In [16462]) Clean up logic when selecting post types for the admin bar content drop-down. see #15308.

[nacin]

I think that a post type should also be publicly_queryable to be listed in the Add New. Ryan agreed but I wanted to post here first.

Reasoning: It's not something viewable on the front end, so why should it be on the admin bar and thus accessible from the front end?

This affects my Log Deprecated Notices plugin, but I don't need this change as I use show_in_menu !== true. That said, the change does have decent reasoning.

[demetris]

I think the attribute title for available updates (x Plugin Updates, y Theme Updates) should encompass the whole Updates item, not just the count bubble.

I attach a patch to explain what I mean.

(If we do that, we will also have to reposition an ID, and also do some CSS tweaking as well.)

[demetris]

attribute title spanning the whole Updates menu item

[nacin]

(In [16463]) Second half of [16462]. props duck_. see #15308.

[ryan]

(In [16610]) Default Add New menu link to first post type in list. Avoids empty href issues. see #15308

[nacin]

(In [16790]) Don't show blurry text shadow in the admin bar count. props demetris, fixes #15308.

[nacin]

Ended up testing my own patch then committing that one, and it doesn't work due to a missing class. Fixing.

[nacin]

Also meant to re-open anyway.

[nacin]

Of course the commit hook would fail for this one.

[16791]

Admin bar styling improvements.

• Ensure there isn't a text shadow for update and comment counts.
• Hide zero count of pending comments via PHP, not CSS.
• Show the update title attribute across the entire menu item, props demetris.
• Let the CSS breathe a little.

[nacin]

(In [16795]) Close a quote. see #15308.

[ocean90]

I will start to clean up the Admin Bar CSS a little bit. One by one and 15308.clean.css.patch is the first one. It removes unused code and lets the CSS breathe more. ;-)

[nacin]

(In [16852]) Admin bar CSS cleaning. props ocean90, see #15308.

[ryan]

With [16852], the debug menu (from the debug-bar plugin) is no longer placed on the right after the search box. Perhaps the plugin needs an update.

​http://plugins.svn.wordpress.org/debug-bar/trunk

[ryan]

Looks like the plugin makes us of the ab-sadmin class. The plugin needs an update.

[ryan]

Perhaps we need a generic ab-float-to-the-end type class that goes right for LTR and left for RTL.

[ryan]

[16862]

[ocean90]

15308.rtl.patch removes the search input value Search (repetition and seems like a remnant from wp.com) and improves RTL styling.

[nacin]

(In [16875]) More admin bar styling improvements. Includes RTL fixes. Don't show redundant 'search' value. props ocean90, see #15308.

[ocean90]

15308.blogname.patch: $blog->domain should be shorten too when $blog->blogname is empty, also revert back to 15 characters, my mistake.

[ocean90]

A question:

if ( ! isset( $blog->visible ) || $blog->visible === true ) {

When will be $blog->visible true or false? On my install it's always undefined.

[nacin]

(In [16952]) Admin bar blogname handling improvements. Kill visible property vestige. props ocean90, fixes #15308.