Make WordPress Core

Opened 14 years ago

Closed 14 years ago

#15315 closed defect (bug) (fixed)

Rework/Remove define('WP_SHOW_ADMIN_BAR' , false);

Reported by: westi's profile westi Owned by: westi's profile westi
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: General Keywords:
Focuses: Cc:


This define is exceptionally fragile and is only designed for core usage.

Rather than use this define we should work more based on the request type and force disable the admin bar in the scenarios where it isn't needed.

Scenarios to disable in:


We need to add something like IFRAME_REQUEST for the cases in the admin where we display a page in an iframe or somewhere else - media upload, press-this, updates

Change History (5)

#1 @westi
14 years ago

(In [16177]) Add define('WP_SHOW_ADMIN_BAR' , false) for now. See #15315.

#2 @ryan
14 years ago

Works for me.

#3 @westi
14 years ago

(In [16221]) Remove WP_SHOW_ADMIN_BAR and go off existing and new defines on page type. See #15315

#4 @westi
14 years ago

The way the plugin installer iframe works may need a little love as I had to set the define conditionally.

I didn't change the call in iframe_header because it is too late in there to have the desired effect.

If you want to hard disable the ADMIN bar you should use a mu-plugin.

#5 @westi
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Pretty sure this is working fine.

There was an issue with the theme install which has been fixed.

Note: See TracTickets for help on using tickets.