Rework/Remove define('WP_SHOW_ADMIN_BAR' , false);

[westi]

This define is exceptionally fragile and is only designed for core usage.

Rather than use this define we should work more based on the request type and force disable the admin bar in the scenarios where it isn't needed.

Scenarios to disable in:

• XMLRPC_REQUEST
• APP_REQUEST
• DOING_AJAX

We need to add something like IFRAME_REQUEST for the cases in the admin where we display a page in an iframe or somewhere else - media upload, press-this, updates

[westi]

(In [16177]) Add define('WP_SHOW_ADMIN_BAR' , false) for now. See #15315.

[ryan]

Works for me.

[westi]

(In [16221]) Remove WP_SHOW_ADMIN_BAR and go off existing and new defines on page type. See #15315

[westi]

The way the plugin installer iframe works may need a little love as I had to set the define conditionally.

I didn't change the call in iframe_header because it is too late in there to have the desired effect.

If you want to hard disable the ADMIN bar you should use a mu-plugin.

[westi]

Pretty sure this is working fine.

There was an issue with the theme install which has been fixed.