WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 6 months ago

#15317 new defect (bug)

My Sites limited to 23 sites on Admin Bar

Reported by: ronbme Owned by:
Milestone: Future Release Priority: low
Severity: normal Version: 3.1
Component: Toolbar Keywords: has-patch
Focuses: multisite Cc:

Description

I have a test site with 25 sites. I can only access 23 from the My Sites tab on the admin bar.

(This is a minor bug, but I hadn't seen it mentioned.)

Ron

I'm using latest trunk.

Attachments (2)

15317.patch (2.4 KB) - added by ocean90 4 years ago.
15317.2.patch (1.3 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (24)

@ocean904 years ago

comment:1 @ocean904 years ago

  • Component changed from General to Administration
  • Keywords has-patch ux-feedback added
  • Milestone changed from Awaiting Review to 3.1
  • Priority changed from normal to low

It's limited to your screen size.

15317.patch - With this patch only the first 15 blogs will be shown and then a link to my-sites.php

comment:2 @westi4 years ago

Limiting the list is problematic because the working length can be screensize dependent

Someone with that many sites probably wants to be able to hide some of them - which would be plugin territory.

comment:3 @ocean904 years ago

  • Keywords has-patch ux-feedback removed
  • Milestone changed from 3.1 to Future Release

Like westi said, a plugin could use the filter in get_blogs_of_user().

comment:4 @Denis-de-Bernardy4 years ago

Couldn't we add something like this in the CSS?

max-height: 600px;
overflow-y: auto; /* or scroll */

comment:5 follow-up: @nacin3 years ago

  • Milestone changed from Future Release to 3.3

WP.com has a scrolling aspect to it. Perhaps we can borrow that behavior, at least as a stopgap.

comment:6 in reply to: ↑ 5 @azaozz3 years ago

Replying to nacin:

Yes but it requires jQuery. Perhaps we can add it only when the admin bar is in the admin.

The css overflow-x/overflow-y don't work there (at least in FF) so the scrolling actually hides the top 3 and shows the bottom 3 links in the submenus (and vice-versa).

comment:7 @ocean903 years ago

#wpadminbar #wp-admin-bar-my-sites-secondary {
	max-height: 500px;
	overflow-y: scroll;
}

could work, but the submenus are hidden.

comment:8 @rekall3 years ago

just added a few sites on a fresh multiuser setup so i could see what the chatter is about...

here's a "what if" scenario:

what if we were to add mouseenter/mouseleave events to the first & last elements of the list (or to two new elements to the list with decorative up/down arrows) to the dropdown such that the cropping properties were to 'slide' the visible portion of the container? this way you could still limit the size of the list, not have to rely on a scrollbar (using overflow-y: scroll) which would conflict with the pop-out menu to the right, and instead provide a more intuitive natural way of scrolling the box up/down at will?

Last edited 3 years ago by rekall (previous) (diff)

comment:9 @ryan3 years ago

  • Component changed from Administration to Admin Bar

comment:10 @ryan3 years ago

  • Milestone changed from 3.3 to Future Release

This is not a regression from 3.2. Let's take care of it in 3.4

@SergeyBiryukov3 years ago

comment:11 @SergeyBiryukov3 years ago

  • Keywords has-patch added

Could we limit the number and make it filterable so that a plugin wouldn't have to resort to get_blogs_of_user filter?

Refreshed 15317.patch for current trunk.

Other solutions would probably require #19979.

comment:12 @Rarst3 years ago

Please note that any toolbar menu is potentially affected and they are not limited to core code, but actively added by extensions as well.

Fixing or providing filters for one specific menu won't address issue in general.

comment:13 @jeremyfelt3 years ago

  • Cc jeremy.felt@… added

comment:14 @ivnus3 years ago

  • Cc ivnus added

comment:15 @ryanduff19 months ago

  • Cc ryan@… added

comment:16 @austinginder19 months ago

  • Cc austinginder added

comment:17 @SergeyBiryukov16 months ago

#26416 was marked as a duplicate.

comment:18 @helen7 months ago

#29295 was marked as a duplicate.

comment:19 follow-up: @trepmal7 months ago

When faced with an unusably long menu, I created a little search feature. Here it is as a plugin: https://github.com/trepmal/my-sites-search

comment:20 in reply to: ↑ 19 @SergeyBiryukov7 months ago

Replying to trepmal:

When faced with an unusably long menu, I created a little search feature. Here it is as a plugin: https://github.com/trepmal/my-sites-search

This looks great and can probably be applied to arbitrary long menus as well (to address comment:12).

comment:21 @mrjarbenne7 months ago

  • Focuses multisite added

That search plugin is great when faced with a menu containing a very large number of items, but would seem to be overkill in instances where the menu is exceeding the size of the screen by only a few lines, particularly in examples where the menu fits on a regular screen, but is obscured on smaller mobile devices. Wouldn't a better solution be to allow for the menu to scroll? As noted by @Rarst, this issue rears its head not only in the My Sites menu, but also in other menus like the Profile on the right, in instances where plugins like BuddyPress add additional items that can exceed the size of the screen: a space where a search window wouldn't remedy the UI issue (see video: http://www.screencast.com/t/siMIp5PJDDL).

I don't think limiting the number of items displayed is necessarily the route that would remedy all of the varied instances in which this issue might occur. On smaller screens (smartphones particularly), the dashboard content is completely obscured by the resulting dropdown menu, making the scrolling of that dashboard content -- hidden behind the menu -- of little use. From a UI perspective, if I am attempting to scroll when on top of the menu, one can assume I am trying to scroll the menu content, and not the content beneath the menu.

comment:22 @ircbot6 months ago

This ticket was mentioned in IRC in #wordpress-dev by ericandrewlewis. View the logs.

Note: See TracTickets for help on using tickets.