Opened 13 years ago
Closed 13 years ago
#15321 closed defect (bug) (fixed)
Leading <li> missing from subsubsub menu items on plugin install page(s)
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.1 | Priority: | normal |
Severity: | normal | Version: | 3.1 |
Component: | Validation | Keywords: | |
Focuses: | Cc: |
Description
Leading <li> missing from subsubsub menu items on plugin install pages(s), looks like it might have been introduced in [15578] (the change to the class mentioned below likely happened before that though)
Results in markup such as this:
<ul class='subsubsub'> <a href='http://localhost/trunk/wp-admin/plugin-install.php?tab=dashboard' class="current">Search</a> |</li> <a href='http://localhost/trunk/wp-admin/plugin-install.php?tab=upload'>Upload</a> |</li> <a href='http://localhost/trunk/wp-admin/plugin-install.php?tab=featured'>Featured</a> |</li> <a href='http://localhost/trunk/wp-admin/plugin-install.php?tab=popular'>Popular</a> |</li> <a href='http://localhost/trunk/wp-admin/plugin-install.php?tab=new'>Newest</a> |</li> <a href='http://localhost/trunk/wp-admin/plugin-install.php?tab=updated'>Recently Updated</a></li> </ul>
Bit hard to track down where/what/when exactly it changed since the class files seem to have shuffled around a lot in the last week or so, but it appears to be its caused due to the leading <li> not being added in the get_views() function in
/wp-admin/includes/class-wp-plugin-install-list-table.php
The leading <li> looks to be added as part of the get_views() function in the other class(es) such as class-wp-plugins-list-table.php and class-wp-posts-list-table.php
Change History (2)
Note: See
TracTickets for help on using
tickets.
[16205]