WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#15328 closed defect (bug) (wontfix)

Always Filter Admin Bar Showing

Reported by: filosofo Owned by: filosofo
Milestone: Priority: normal
Severity: normal Version: 3.1
Component: General Keywords: has-patch
Focuses: Cc:

Description

We can't anticipate every use of the admin bar, and there's no great performance benefit in short-circuiting the show_admin_bar filter as done in r16221.

For example, suppose someone wants to load the admin bar markup asynchronously. It would be helpful to be able to turn it on when DOING_AJAX is true.

Attachments (1)

always-filter-admin-bar-showing.15328.diff (590 bytes) - added by filosofo 3 years ago.

Download all attachments as: .zip

Change History (2)

comment:1 westi3 years ago

  • Milestone 3.1 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

We have to short circuit it because it calls functions that should not be called for some of these request types.

Which then leads to nasty things like broken XMLRPC endpoints.

Note: See TracTickets for help on using tickets.