AJAX plugin pagination issues

[johnbillion]

I'm out of the loop at the moment so forgive me if this is work in progress.

When paging through the Plugins screen (with the new AJAX pagination) the 'activate' and 'deactivate' links are missing.

To reproduce: Go to the Plugins screen and page through your plugins.

Tested at r16230. Marking as a blocker because, well, it is.

[nacin]

Reproduced.

[westi]

(In [16231]) Ensure that booleans are booleans for now. See #15336.

[westi]

This is caused by the way the current_screen object is being re-incarnated.

Currently we trust whatever we receive in the GET request which is always going to be string data.

I've added the casts for now two force the two bools to be bools.

However, I'm not convinced this is the best solution for passing this data back from the JavaScript as it is now we blindly trust the data we receive.

Is any of it used in subsequent output?

[Utkarsh]

$curent_screen ?

[westi]

Replying to Utkarsh:

$curent_screen ?

Typo :-(

[Utkarsh]

Still getting

An error has occured while loading the items.

AJAX response is

<b>Fatal error</b>:  Cannot use object of type stdClass as array in <b>..\wp-admin\admin-ajax.php</b> on line <b>57</b><br />

Should probably use ->is_network and ->is_user?

[westi]

I need to drink more coffee before coding :-(

[ocean90]

->is_network doesn't work too.
string(5) "false" with (bool) = bool(true)
:-(
See [16194]

[westi]

(In [16234]) Fix typo. See #15336 props Utkarsh.
Also actually correctly cast to boolean :-)

[scribu]

However, I'm not convinced this is the best solution for passing this data back from the JavaScript as it is now we blindly trust the data we receive.

Is any of it used in subsequent output?

Yes, of course it is used.

[scribu]

I guess we could just pass hook_suffix and make set_current_screen() handle it.

[scribu]

I'm going to call this fixed. Maybe find a better way to handle it in WP 3.2.