Context Navigation

← Previous Ticket
Next Ticket →

#15377 closed defect (bug) (fixed)

Allow screen_icon() to return not echo

Reported by:	aaroncampbell	Owned by:
Priority:	normal	Milestone:	3.2
Component:	Administration	Version:
Severity:	normal	Keywords:	has-patch dev-feedback
Cc:		Focuses:

Description

I'd like to see screen_icon() be able to return it's value rather than just echo it. I'm willing to patch it, but are we trying to stick to the get_*() functions, or do we want another parameter?

Attachments (3)

15377.001.diff (1.7 KB ) - added by aaroncampbell 16 years ago.
15377.002.diff (818 bytes ) - added by aaroncampbell 15 years ago.
15377.003.diff (824 bytes ) - added by aaroncampbell 15 years ago.

Download all attachments as: .zip

Change History (12)

#1 @nacin
16 years ago

get_* would be nice.

#2 @nacin
16 years ago

Keywords needs-patch added; dev-feedback removed
Milestone Awaiting Review → Future Release

@aaroncampbell
16 years ago

Attachment 15377.001.diff added

#3 @aaroncampbell
16 years ago

Keywords has-patch added; needs-patch removed

The patch adds get_screen_icon() and uses it in screen_icon(). The only change is to use esc_attr on $name which is used as part of the div id.

@aaroncampbell
15 years ago

Attachment 15377.002.diff added

#4 @aaroncampbell
15 years ago

Keywords 3.2-early added

Patch for the current trunk.

#5 @westi
15 years ago

Why not just build a string rather than use sprintf?

@aaroncampbell
15 years ago

Attachment 15377.003.diff added

#6 @aaroncampbell
15 years ago

Good point. New patch without sprintf

#7 @aaroncampbell
15 years ago

Keywords 3.2-early removed
Milestone Future Release → 3.2

#8 @jane
15 years ago

Keywords dev-feedback added

#9 @ryan
15 years ago

Resolution → fixed
Status new → closed

(In [17656]) Introduce get_screen_icon(). Props aaroncampbell. fixes #15377

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#15377 closed defect (bug) (fixed)

Allow screen_icon() to return not echo

Description

Attachments (3)

Change History (12)

#1 @nacin 16 years ago

#2 @nacin 16 years ago

@aaroncampbell 16 years ago

#3 @aaroncampbell 16 years ago

@aaroncampbell 15 years ago

#4 @aaroncampbell 15 years ago

#5 @westi 15 years ago

@aaroncampbell 15 years ago

#6 @aaroncampbell 15 years ago

#7 @aaroncampbell 15 years ago

#8 @jane 15 years ago

#9 @ryan 15 years ago

Download in other formats:

#1 @nacin
16 years ago

#2 @nacin
16 years ago

@aaroncampbell
16 years ago

#3 @aaroncampbell
16 years ago

@aaroncampbell
15 years ago

#4 @aaroncampbell
15 years ago

#5 @westi
15 years ago

@aaroncampbell
15 years ago

#6 @aaroncampbell
15 years ago

#7 @aaroncampbell
15 years ago

#8 @jane
15 years ago

#9 @ryan
15 years ago