WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#15379 closed defect (bug) (duplicate)

is_email should be RFC complient

Reported by: jorbin Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords: needs-unit-test
Focuses: Cc:

Description

#blamenacin

Attachments (2)

email.php (8.8 KB) - added by jorbin 5 years ago.
email.patch (8.8 KB) - added by jorbin 5 years ago.

Download all attachments as: .zip

Change History (11)

@jorbin5 years ago

comment:1 @ryanduff5 years ago

I like this alot.

comment:2 @westi5 years ago

  • Resolution set to duplicate
  • Status changed from new to closed

Duplicate of #4616

@jorbin5 years ago

comment:3 @ryan5 years ago

Viewing that regex will insert a malicious easter egg in your brain.

comment:4 @mrmist5 years ago

There are alot of slashes in that patch. Can we use less? They are a natural resource after all.

comment:5 @nacin5 years ago

Willing to commit this if you can produce 100% unit test coverage. I'll wait.

comment:6 @jorbin5 years ago

  • Keywords needs-unit-test added

This patch has one main flaw and that is the lack of a capital P I think it needs-improvement

comment:7 @coffee2code5 years ago

Hmm, looks like that one parenthesis is out of place...

comment:8 follow-up: @filosofo5 years ago

If we wait until 3.2 with PHP 5.x, we can just do

filter_var( $email, FILTER_VALIDATE_EMAIL ) instead, right?

comment:9 in reply to: ↑ 8 @nacin5 years ago

  • Milestone Awaiting Review deleted

Replying to filosofo:

If we wait until 3.2 with PHP 5.x, we can just do

filter_var( $email, FILTER_VALIDATE_EMAIL ) instead, right?

Probably not. Those can be buggy. We could potentially leverage it internally but we need to watch out for vulnerabilities and what not across PHP versions.

Note: See TracTickets for help on using tickets.