WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 17 months ago

#15385 closed enhancement (wontfix)

Use get_template_part() for post formats in Twenty Ten

Reported by: nacin Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

Let's encourage some standardization in themes by giving Twenty Ten the following:

get_template_part( 'post-format', 'aside' );
get_template_part( 'post-format', 'gallery' );

We'll leave the default in loop.php, I'm thinking, though we could also use post-format-default.

I'm going to comment on #14746 that I think, if post formats are supported, then 'default' should always be supported and should be enforced as the default, even if nothing is stored yet for that post.

Attachments (1)

15385.diff (21.7 KB) - added by nacin 5 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 @markmcwilliams5 years ago

I'd never thought about that, can see logic behind it though! :)

@nacin5 years ago

comment:2 @nacin5 years ago

Patch attached.

Something doesn't quite feel right. I don't know if it's the arguments in get_template_part(), or the fact that the default styling remains in loop.php, or something.

comment:3 @markjaquith5 years ago

  • Milestone changed from 3.1 to Future Release

Punt.

comment:4 @azizur5 years ago

  • Cc azizur added

comment:5 @SergeyBiryukov3 years ago

  • Component changed from Themes to Bundled Theme

comment:6 @SergeyBiryukov2 years ago

  • Milestone changed from Future Release to WordPress.org

comment:7 @lancewillett17 months ago

  • Milestone WordPress.org deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing as we don't have plans to implement this Twenty Ten enhancement; we're focusing on improving and making newer themes.

Note: See TracTickets for help on using tickets.