Make WordPress Core

Opened 16 years ago

Closed 13 years ago

#15385 closed enhancement (wontfix)

Use get_template_part() for post formats in Twenty Ten

Reported by: nacin Owned by:
Priority: normal Milestone:
Component: Bundled Theme Version:
Severity: normal Keywords:
Cc: Focuses:

Description

Let's encourage some standardization in themes by giving Twenty Ten the following:

get_template_part( 'post-format', 'aside' );
get_template_part( 'post-format', 'gallery' );

We'll leave the default in loop.php, I'm thinking, though we could also use post-format-default.

I'm going to comment on #14746 that I think, if post formats are supported, then 'default' should always be supported and should be enforced as the default, even if nothing is stored yet for that post.

Attachments (1)

15385.diff​ (21.7 KB ) - added by nacin 16 years ago.

Download all attachments as: .zip

Change History (8)

#1 @markmcwilliams
16 years ago

I'd never thought about that, can see logic behind it though! :)

@nacin
16 years ago

#2 @nacin
16 years ago

Patch attached.

Something doesn't quite feel right. I don't know if it's the arguments in get_template_part(), or the fact that the default styling remains in loop.php, or something.

#3 @markjaquith
16 years ago

  • Milestone 3.1 → Future Release

Punt.

#4 @azizur
16 years ago

  • Cc azizur added

#5 @SergeyBiryukov
14 years ago

  • Component Themes → Bundled Theme

#6 @SergeyBiryukov
14 years ago

  • Milestone Future Release → WordPress.org

#7 @lancewillett
13 years ago

  • Milestone WordPress.org
  • Resolution → wontfix
  • Status new → closed

Closing as we don't have plans to implement this Twenty Ten enhancement; we're focusing on improving and making newer themes.

Note: See TracTickets for help on using tickets.