Error suppression in wp-db is lame

[westi]

WARNING: wp-includes/wp-db.php:1018 - mysql_free_result() expects parameter 1 to be resource, boolean given

This is suppressed by an @ but is probably a bug.

We should try and get rid of all the error suppressions.

[westi]

[16320] introduced this warning.

[nacin]

We call wpdb::flush() immediately in wpdb::query(). That means that originally, _mysql_last_result is still null, rather than holding a resource.

[nacin]

mysql_free_result() returns true on success, false on failure, and only emits a warning if called on a non-resource. A simple is_resource() check is thus enough to remove the error suppression there, as another type of resource should never get in there.

[nacin]

(In [16321]) Only mysql_free_result if we have a valid resource, and remove error suppression there. see #15402.

[nacin]

One operator down, 19 to go. :-)

[miqrogroove]

Duplicates #11151, still on Future Release.

[miqrogroove]

Have you seen my work on MySQL error handling in XMB?

[nacin]

Closing as fixed based on mysql_free_result().

Moving #11151 to 3.1 and cc'ing westi.

Have you seen my work on MySQL error handling in XMB?

Please link to that in the other ticket if you feel it's helpful.