WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 8 years ago

#1541 closed defect (bug) (fixed)

Pingback source URIs are no longer checked for a valid link (!!!)

Reported by: markjaquith Owned by: markjaquith
Milestone: Priority: highest omg bbq
Severity: critical Version: 1.6
Component: Administration Keywords: bg|has-patch bg|commit
Focuses: Cc:

Description

In both 1.6 SVN and /branches/1.5/, pingback "from" URIs are no longer checked to see if they have a valid link!

This change happened when Denis' improved excerpt code was inserted. The old code was taken out... including the part that verifies that the link exists.

This definitely needs to get fixed before a 1.5.1.4 release is made from the 1.5 code branch, or Pingback will suddenly be as wide open as Trackback to spammers. How do you think I discovered this bug? ;-)

Attachments (2)

xmlrpc.php_1.5-branch.diff (531 bytes) - added by markjaquith 10 years ago.
Patch for 1.5 branch
xmlrpc.php_1.6-svn.diff (528 bytes) - added by markjaquith 10 years ago.
Patch for 1.6 SVN

Download all attachments as: .zip

Change History (10)

comment:1 @markjaquith10 years ago

  • Status changed from new to assigned

comment:2 @markjaquith10 years ago

  • Milestone changed from 2.0 to 1.6

@markjaquith10 years ago

Patch for 1.5 branch

@markjaquith10 years ago

Patch for 1.6 SVN

comment:3 @markjaquith10 years ago

  • Keywords bg|has-patch bg|commit added; bg|dev-feedback bg|needs-patch removed

comment:4 @markjaquith10 years ago

  • Summary changed from Pingback URIs are no longer validated (!!) to Pingback source URIs are no longer checked for a valid link (!!!)

comment:5 @matt10 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [2742]) Fixes #1541

comment:6 @markjaquith10 years ago

  • Milestone changed from 1.6 to 1.5.2
  • Resolution fixed deleted
  • Status changed from closed to reopened

Okay, fixed for 1.6, but we still need this in /branches/1.5/ for that 1.5.2 release.

comment:7 @matt10 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [2778]) Re fixes #1541

comment:8 @anonymous8 years ago

  • Milestone 1.5.2 deleted

Milestone 1.5.2 deleted

Note: See TracTickets for help on using tickets.