WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 18 months ago

Last modified 17 months ago

#15411 closed defect (bug) (fixed)

site-users.php should use API to fetch roles

Reported by: ryan Owned by:
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Multisite Keywords:
Focuses: Cc:

Description

get_blog_option( $id, "{$blog_prefix}user_roles" )

That won't work on sites that hard code a roles array in memory. API should be used to fetch the roles. Otherwise you can end up with:

Warning: Invalid argument supplied for foreach() in /..l/wp-admin/network/site-users.php on line 149

Change History (5)

comment:1 ryan3 years ago

  • Summary changed from site-users.php should use API top fetch roles to site-users.php should use API to fetch roles

comment:2 ryan3 years ago

(In [16370]) Handle sites that hard-code roles rather than storing them in the DB. Temp hack. see #15411

comment:3 ryan3 years ago

  • Milestone changed from 3.1 to Future Release

comment:4 wonderboymusic18 months ago

  • Milestone changed from Future Release to 3.5
  • Resolution set to fixed
  • Status changed from new to closed

The "temp hack" added in [16370] existed until [21414] when it was removed

comment:5 nacin17 months ago

A "temp hack" we actually removed eventually? Woohoo!

Note: See TracTickets for help on using tickets.