Make WordPress Core

Opened 14 years ago

Closed 14 years ago

Last modified 4 years ago

#15413 closed defect (bug) (fixed)

inconsistent use of home_url() in author-template.php

Reported by: chineseleper's profile chineseleper Owned by: markjaquith's profile markjaquith
Milestone: 3.1 Priority: normal
Severity: minor Version: 3.1
Component: Permalinks Keywords: has-patch
Focuses: Cc:

Description

should be

home_url(trailingslashit($link))

not

home_url().trailingslashit($link)

in

get_author_posts_url()

Attachments (1)

author-template.patch (526 bytes) - added by chineseleper 14 years ago.
Patch

Download all attachments as: .zip

Change History (8)

#1 @nacin
14 years ago

  • Milestone changed from Awaiting Review to 3.1

Best to diff from the root, that way the path in the patch includes wp-includes.

We'd also want to add some whitespace there, i.e. home_url( trailingslashit( $link ) ).

#2 @chineseleper
14 years ago

patch updated

#3 @kapeels
14 years ago

  • Keywords has-patch added

#4 @markjaquith
14 years ago

  • Owner set to markjaquith
  • Status changed from new to assigned

Looks like it got fixed, but there is another that I see.

#5 @markjaquith
14 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [16425]) The path goes INSIDE home_url(). fixes #15413

#6 @nacin
14 years ago

Fixed it in [16401] when moving to user_trailingslashit.

This ticket was mentioned in Slack in #core-editor by bobbingwide. View the logs.


4 years ago

Note: See TracTickets for help on using tickets.