WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 9 months ago

#15414 closed defect (bug) (invalid)

Rework admin searches and make them compatible with no-js again

Reported by: ocean90 Owned by: ocean90
Milestone: Priority: normal
Severity: normal Version: 3.1
Component: Administration Keywords:
Focuses: Cc:

Description (last modified by ocean90)

I'm working on #15355 and found some problems with the searches. I will use this ticket to add the patches, one patch for each problem which I have found.

A list with what it not working:

  • Comments search doesn't work without JS fixed
  • Users search doesn't work with and without JS fixed
  • http://grab.by/7nC2 I like the idea with the new tab "Search Results (1)", but you will see it only in no-js version and only for themes and plugins search. We should add it for all searches, AJAX search and with no grey bgcolor to be consistent. Or we must respect the active tab like we did it on comments search, so if 'Sticky' tab is active search only through sticky posts and not all as it is yet. Consistent is the word here.
  • Behaviour after a search without any results: With JS it's an empty table and with no-js we have the message "No xxx found."

Attachments (1)

15414.plugin.search.patch (3.8 KB) - added by ocean90 3 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 ocean903 years ago

  • Owner set to ocean90
  • Status changed from new to accepted

comment:2 ocean903 years ago

  • Description modified (diff)

comment:3 nacin3 years ago

Also, what's with the styling of "Search Results (1)"? I saw that the other day while giving a demo.

comment:4 ocean903 years ago

  • Description modified (diff)

I'm working on #15355 and found some problems with the searches. I will use this ticket to add the patches, one patch for each problem which I have found.

A list with what it not working:

  • Comments search doesn't work without JS
  • Users search doesn't work with and without JS
  • http://grab.by/7nC2 I like the idea with the new tab "Search Results (1)", but you will see it only in no-js version and only for themes and plugins search. We should add it for all searches, AJAX search and with no grey bgcolor to be consistent. Or we must respect the active tab like we did it on comments search, so if 'Sticky' tab is active search only through sticky posts and not all as it is yet. What do you think?

comment:5 ocean903 years ago

  • Description modified (diff)
  • Keywords ux-feedback added
  • Severity changed from normal to major

So my opionion is to use the same behaviour like comments search.

comment:6 ocean903 years ago

Related: #15170

comment:7 voyagerfan57613 years ago

  • Cc WordPress@… added

comment:8 ocean903 years ago

  • Description modified (diff)

comment:9 ocean903 years ago

  • Priority changed from high to normal
  • Severity changed from major to normal

15414.plugin.search.patch is the first patch. With it only the plugins of the current status will be searched, same as by the comment searches. It adds also the table navigation for mustuse and dropins plugins, I don't know why there shouldn't be one.
Now the question: Is this needed? Should it be for all searches? If yes, I will do it.

comment:10 JohnONolan3 years ago

Any relevant UI screenshots for the patch? Just checking

comment:11 ocean903 years ago

JohnONola: There won't be any UI changes.

comment:12 ryan3 years ago

  • Milestone changed from 3.1 to Future Release

comment:13 ocean909 months ago

  • Keywords needs-patch ux-feedback removed
  • Milestone Future Release deleted
  • Resolution set to invalid
  • Status changed from accepted to closed

The ticket was related to #14579.

Note: See TracTickets for help on using tickets.