WordPress.org

Make WordPress Core

Changes between Version 2 and Version 4 of Ticket #15414


Ignore:
Timestamp:
11/13/10 14:41:54 (3 years ago)
Author:
ocean90
Comment:

I'm working on #15355 and found some problems with the searches. I will use this ticket to add the patches, one patch for each problem which I have found.

A list with what it not working:

  • Comments search doesn't work without JS
  • Users search doesn't work with and without JS
  • http://grab.by/7nC2 I like the idea with the new tab "Search Results (1)", but you will see it only in no-js version and only for themes and plugins search. We should add it for all searches, AJAX search and with no grey bgcolor to be consistent. Or we must respect the active tab like we did it on comments search, so if 'Sticky' tab is active search only through sticky posts and not all as it is yet. What do you think?

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #15414 – Description

    v2 v4  
    44 - Comments search doesn't work without JS 
    55 - Users search doesn't work with and without JS 
    6  - http://grab.by/7nC2 I like the idea with the new tab "Search Results (1)", but you will see it only in no-js version and only for themes and plugins search. We should add it for all searches, AJAX search and with no grey bgcolor to be consistent and to make the user clear, that he doesn't search for only published posts but rather for all post statuses. What do you think? 
     6 - http://grab.by/7nC2 I like the idea with the new tab "Search Results (1)", but you will see it only in no-js version and only for themes and plugins search. We should add it for all searches, AJAX search and with no grey bgcolor to be consistent. '''Or''' we must respect the active tab like we did it on comments search, so if 'Sticky' tab is active search only through sticky posts and not all as it is yet. Consistent is the word here.