Bulk edit on paginated edit.php takes you back to the first page

[nacin]

Side note: Shouldn't we have hashes for pagination? Otherwise we present ourselves a UX issue for links being copy-pasted.

[scribu]

Related: ​http://core.trac.wordpress.org/ticket/14579#comment:140

[garyc40]

Patch attached.

The reason why it gets redirected to the original page is because in edit.php (as well as edit-comments.php), wp_get_referer() is processed to feed the redirected URL back to wp_redirect().

This means, when you go directly to edit.php?paged=3 for example, then use the javascript pagination feature to navigate to page 4, and do some bulk action there, you'll be redirected to page 3 nevertheless.

Both edit.php and edit-comments.php have this bug. The attached patch fixes it for both. Also, when you delete post / comments on the last page, normally you'll be redirected to a page that says "No posts found". This patch fixes it as well (by redirecting to the correct last page).

[scribu]

Please keep property changes (svn:ignore in this case) out of patches.

[garyc40]

removed prop changes from patch

[garyc40]

Patch updated.

Btw, is there any way I can leave out the property changes when using "svn diff" ? Is there any command line options for that? Googled around a bit but couldn't find any answers.

[scribu]

Replying to garyc40:

Patch updated.

Thanks.

Btw, is there any way I can leave out the property changes when using "svn diff" ? Is there any command line options for that? Googled around a bit but couldn't find any answers.

Don't know. Instead, here's an alias for svn stat that doesn't list unknown files:

mod(){
	svn stat --ignore-externals | grep '^[^?X]'
}

Taken from here: ​http://andrewnacin.com/2010/05/13/my-wordpress-bash-functions/

[scribu]

(In [16855]) Redirect to correct page after bulk action for posts and comments. Props garyc40. Fixes #15416

[scribu]

This works because of the input in the new pagination style. Lucky break :)

[scribu]

(In [16856]) Remove unnecessary comments. See #15416

[hakre]

Related: #16162

[ocean90]

hakre, please don't reopen all the tickets, create new ones, in this case it's #16166.
The problem mentioned by nacin is fixed here.

[hakre]

Yeah right, the title says "first page", not "wrong page". Right. Fixed in the sense of this title. Mind me, re-opening was in the process to find related tickets.

Does this "needs-testing" has any more meaning on this one?