WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#15423 closed enhancement (fixed)

Add consistency for the `type` argument between get_comments and wp_list_comments

Reported by: oncletom Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version:
Component: Comments Keywords:
Focuses: Cc:

Description

Hello,

I wanted to use get_comments to display in a separate way comments and pings (trackbacks + pingbacks... or whatever is not a comment published by users on the blog).

However, I realized despite get_comments and wp_list_comments, the pings value for this latest function does not work with get_comments.

I saw there are some filters planned for get_comments but I think it's more a usage case I'm discussing of.

2 things could be done, IMHO:

  • type argument could be an array (to collect many types of comment at a type, especially custom comments type, like tweetbacks etc.)
  • type values should be harmonized: the ones working with wp_list_comments would work with get_comments (comment, trackback, pingback, ping) − all plural, or all singular, depending if we talk about a comment type, or a comment type quantity

Hope it helps :)

Change History (1)

comment:1 nacin3 years ago

  • Milestone changed from Awaiting Review to 3.1
  • Resolution set to fixed
  • Status changed from new to closed

'pings' now works in get_comments() in 3.1. It can also be 'comment', 'trackback', and 'pingback'. Closing as fixed.

Note: See TracTickets for help on using tickets.