WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#15430 closed enhancement (fixed)

Improved label for oEmbed toggle in Settings

Reported by: RanYanivHartstein Owned by: nacin
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: UI Keywords: has-patch
Focuses: Cc:

Description

The current label for the oEmbed toggle in Settings is:

Attempt to automatically embed all plain text URLs

See this under Settings > Media.

This is a bit too technical. I suggest a more descriptive label:

Attempt to automatically embed all plain text URLs, such as links to videos or images

Attachments (1)

15430.diff (1.2 KB) - added by JohnONolan 4 years ago.
Fixes #15430

Download all attachments as: .zip

Change History (14)

comment:1 @Viper007Bond4 years ago

  • Component changed from Embeds to UI
  • Milestone changed from Awaiting Review to Future Release

comment:2 @Viper007Bond4 years ago

  • Milestone changed from Future Release to 3.1

Whoops, I was thinking we were string frozen for some dumb reason.

comment:3 @westi4 years ago

  • Cc westi added
  • Keywords ui-feedback added

comment:4 @JohnONolan4 years ago

FWIW - I'm a pretty advanced user and I understand the meaning of neither of those. I just had to look up what oEmbed does.

Suggestion:
When possible, embed the content from a URL directly onto the page. For example: image and video links.

Reasoning:
"Automatically" is assumed to be true if the option is enabled, no need to describe it.
"Plain text" is relevant but confusing in this context.
"Attempt to" is confusing. Why is it attempting to? Why can't it just do it? "when possible" clears this up. Sometimes it's possible, sometimes it isn't.

comment:5 @Viper007Bond4 years ago

See, this is why I don't do UIs. :)

comment:6 @nacin4 years ago

  • Keywords ux-feedback added; ui-feedback removed

s/ui/ux/ on the keyword.

I agree with John that both strings (current. proposed) are bad.

John's proposal is better, but I'd go with "For example, links to images or videos." as they aren't strictly image links themselves.

Not necessarily against to actually citing YouTube and Flickr directly in there, either. We already reference Google, etc. in options-privacy, and I don't mind giving a contemporary example here either. Thoughts?

comment:7 @JohnONolan4 years ago

Nice touch RE "links to" - agreed

I considered a youtube example but eventually decided against it purely because it's probably too much content for such a small option. In the long run I would love to see a little (i) icon beside stuff like this, and when you click on it the contextual-help menu opens. (or something)

comment:8 @JohnONolan4 years ago

*with more details on that specific element

comment:9 follow-up: @studionashvegas4 years ago

I would suggest just a simple rephrasing:

Attempt to automatically convert all plain text URLs, such as links to videos or images, to display in their correct format (embedded video, image, etc.).

comment:10 in reply to: ↑ 9 @jane4 years ago

Replying to studionashvegas:

links to videos or images, to display in their correct format (embedded video, image, etc.).

They aren't linking to images or videos, but to pages containing images or videos.
I'm with nacin, reference youtube.

comment:11 @JohnONolan4 years ago

  • Keywords needs-patch added; ux-feedback removed
  • Owner set to nacin
  • Status changed from new to assigned

Just went over this with Jane - version below is signed off:

When possible, embed the media content from a URL directly onto the page. For example: links to Flickr and YouTube.

@JohnONolan4 years ago

Fixes #15430

comment:12 @JohnONolan4 years ago

  • Keywords has-patch added; needs-patch removed

Ready to roll.

comment:13 @scribu4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [16557]) Improve oEmbed toggle label. Props JohnONolan. Fixes #15430

Note: See TracTickets for help on using tickets.