WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #15454, comment 20


Ignore:
Timestamp:
12/25/2010 07:06:18 PM (10 years ago)
Author:
nacin
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #15454, comment 20

    initial v1  
    11I'm satisfied that there are no more regressions caused by [16431].
    22
    3 Everything in garyc40-15454-rev3.patch is handled by a commit, [attachment:15454.diff], or is in press-this.php, which there's no need to touch. (We've broken press-this enough this cycle.)
     3Everything in garyc40-15454-rev3.patch is either handled by a recent commit or [attachment:15454.diff]. Or, it's in press-this.php, which there's no need to touch. (We've broken press-this enough this cycle.)
    44
    55Leaving open for final review by ryan. Suggesting commit [attachment:15454.diff] and close as fixed for 3.1, and we can revisit textarea_escaped instances in a new ticket. Alternatively, punt to 3.2-early, but a note on the attachment, esc_html() handles everything that esc_textarea() does except that it does not re-escape, and it does not handle `&`. So it should be considered safe. (And is far less destructive.)