WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#15479 closed defect (bug) (fixed)

User pagination is broken

Reported by: ocean90 Owned by: scribu
Milestone: 3.1 Priority: high
Severity: major Version:
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

On network and site the pagination seems to be broken.

Example: 5 items, 1 per page. first page = 1 item, second page = 2 items, third page = 3 items, fourth page = 1 item

Attachments (2)

15479.diff (539 bytes) - added by duck_ 3 years ago.
total.15479.diff (675 bytes) - added by scribu 3 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 scribu3 years ago

  • Priority changed from normal to high

comment:2 scribu3 years ago

  • Summary changed from User AJAX pagination is broken to User pagination is broken

It seems regular pagination is broken too.

duck_3 years ago

comment:3 duck_3 years ago

  • Keywords has-patch added; needs-patch removed

Looks like limit row count should just be number.

comment:4 scribu3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [16473]) Fix user pagination. Props duck_. Fixes #15479

comment:5 scribu3 years ago

  • Keywords needs-patch added; has-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

The page count drops to 0 for anything except the first one.

scribu3 years ago

comment:6 scribu3 years ago

  • Keywords has-patch added; needs-patch removed
  • Severity changed from normal to major

It seems I mistakenly included the LIMIT clause in the query that counts the total users.

comment:7 automattor3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [17034]) Don't limit total_users. props scribu, fixes #15479.

Note: See TracTickets for help on using tickets.