WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#15480 closed defect (bug) (fixed)

JS sorting should set sorted arrow on both header and footer

Reported by: batmoo Owned by: scribu
Milestone: 3.1 Priority: normal
Severity: minor Version:
Component: Administration Keywords: has-patch ui-feedback
Focuses: Cc:

Description

Currently, JS sorting only sets the sorted arrow for the context clicked (i.e. thead OR tfoot). The arrow should be added to both.

Attachments (2)

15480.diff (635 bytes) - added by batmoo 3 years ago.
15480_using_index.diff (688 bytes) - added by batmoo 3 years ago.
Improved version that uses index

Download all attachments as: .zip

Change History (7)

batmoo3 years ago

comment:1 batmoo3 years ago

  • Keywords ui-feedback added; ui removed

batmoo3 years ago

Improved version that uses index

comment:2 batmoo3 years ago

Updated alternate patch that's likely better since it uses the index of the header instead of matching based on text.

One inherent problem with the arrows, though, is that because we're using a CSS :hover, clicking to sort changes the arrow in the right direction, but the :hover kicks in and the arrow flips in the opposite direction. Unhovering reverts it back in the right direction. That should probably be fixed since it makes things confusing.

comment:3 nacin3 years ago

  • Milestone changed from Awaiting Review to 3.1

comment:4 scribu3 years ago

  • Owner set to scribu
  • Status changed from new to accepted

comment:5 scribu3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [16887]) Set both column header sorting arrows. Props batmoo. Fixes #15480

Note: See TracTickets for help on using tickets.