WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#15485 closed defect (bug) (fixed)

Inserting links is not working in Internet explorer 7/8

Reported by: designsimply Owned by: koopersmith
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: TinyMCE Keywords:
Focuses: Cc:

Description

Inserting links is not working in Internet Explorer 7/8.

To reproduce in IE8, open any post or page, highlight text, click link insert button, add URL, click Update. On clicking update, a Javascript error appears: http://d.pr/r01z

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729)
Timestamp: Fri, 19 Nov 2010 09:59:33 UTC


Message: 'childNodes' is null or not an object
Line: 1
Char: 1976
Code: 0
URI: http://design5279.com/trunk/wp-includes/js/tinymce/plugins/wplink/js/wplink.js?ver=20101119


Message: Invalid argument.
Line: 2
Char: 37740
Code: 0
URI: http://design5279.com/trunk/wp-includes/js/tinymce/wp-tinymce.php?c=1&ver=3392a

In IE7, I cannot open the link dialogue window at all because the TinyMCE icons don't show up for me in IE7. See http://d.pr/niqt

Line: 674
Char: 1
Error: 'tinyMCE' is undefined
Code: 0
URL: http://design5279.com/trunk/wp-admin/post-new.php

Attachments (3)

15485.diff (922 bytes) - added by koopersmith 4 years ago.
ie8.fixes.diff (5.8 KB) - added by koopersmith 4 years ago.
oh.come.on.ie7.are.you.serious.its.just.a.comma.diff (2.9 KB) - added by koopersmith 4 years ago.

Download all attachments as: .zip

Change History (12)

@koopersmith4 years ago

comment:1 @designsimply4 years ago

I still can't get inserting a link to work in IE8. The behavior has changed a little though. Now the link seems to get placed at the top of the page above the WordPress logo instead of in the editor textarea. I can't see the visual editor options in IE7 at all.

Tested with r16488 and 15485.diff in IE8: http://screencast.com/t/P2kOexVZ
Tested with r16488 and 15485.diff in IE7: http://screencast.com/t/ZqP9Dx7ZN

comment:2 @ryan4 years ago

(In [16490]) wplink IE fixes. Props koopersmith. see #15485

comment:3 @ryan4 years ago

  • Milestone changed from Awaiting Review to 3.1

designsimply, js and css patches require extra work to apply. The js and css must be minified unless you have SCRIPT_DEBUG set to true in wp-config.php to indicate you want the develop versions. That could be why the patch didn't work for you.

comment:4 @designsimply4 years ago

Thanks ryan! :) Okay, I updated to r16495 turned on SCRIPT_DEBUG:

$ grep _DEBUG wp-config.php 
 * It is strongly recommended that plugin and theme developers use WP_DEBUG
define( 'WP_DEBUG', true );
define( 'SCRIPT_DEBUG', true );

Here are my test results with r16495 and SCRIPT_DEBUG = true: http://screencast.com/t/NrhtgxF809P (00:01:42)

This time I see js errors on tiny_mce.js instead of wplink.js:

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729)
Timestamp: Fri, 19 Nov 2010 21:47:20 UTC

Message: 'parentNode' is null or not an object
Line: 1
Char: 61377
Code: 0
URI: http://design5279.com/trunk/wp-includes/js/tinymce/tiny_mce.js?ver=3392a

Message: Invalid argument.
Line: 1
Char: 37740
Code: 0
URI: http://design5279.com/trunk/wp-includes/js/tinymce/tiny_mce.js?ver=3392a

comment:5 @andrewspittle4 years ago

  • Cc andrewspittle added

comment:6 @nacin4 years ago

  • Owner set to koopersmith
  • Status changed from new to reviewing
  • Version set to 3.1

@koopersmith4 years ago

comment:7 @nacin4 years ago

(In [16500]) IE8 fixes for internal linking. props koopersmith, see #15485, see #11420.

comment:8 @designsimply4 years ago

Inserting links now works in IE8. Beautiful!

I still can't get it to work in IE7 though.

Test results with r16504, SCRIPT_DEBUG = true and IE7: http://screencast.com/t/EgQFsrbJ

On page load, I see this error in IE7:

Line: 2
Char: 996
Error: Expected identifier, string or number
Code: 0
URL: http://design5279.com/trunk/wp-admin/post-new.php

When I highlight text and click the link icon, I see this error in IE7:

Line: 2
Char: 4438
Error: 'undefined' is null or not an object
Code: 0
URL: http://design5279.com/trunk/wp-admin/post-new.php

Based on the fact that I see js errors on page load, I think this may be a more general TinyMCE or js problem, but I'm not sure. Should I open a new trac ticket for the js errors shown above?

comment:9 @nacin4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

(In [16532]) Yeah, about that comma... Fix internal linking for both IE6 and IE7. props koopersmith, fixes #15485.

Note: See TracTickets for help on using tickets.