Custom permalinks redirecting back to category list instead of post

[tott]

Using a custom permalink structure such as

/%category%/%post_id%/%postname%/

hitting a post permalink will redirect you back to the category although debugging via a filter attached to parse_request shows the correct query (matched_query).

[ryan]

[15825]

[ryan]

canonical.php is confused. I think it sees this as a tax query rather than a single post query.

[mtekk]

It is broken for all instances of %category% in your permalinks e.g. /archives/%category%/%postname% is broken as well

[mtekk]

The latest revision that it works on is [16379], it is broken by the next revision [16380]

[markjaquith]

is_category is being set, and it shouldn't be.

[markjaquith]

Do not set is_(category|tag|tax) for is_singular

[markjaquith]

(In [16495]) Do not set is_category/is_tax/is_tax for is_singular requests. props mtekk. fixes #15487

[mtekk]

Still broken, and is sort of worse now. Can end up in infinite redirect loops, or lead to pages instead of posts. Must be more to this, unless I have borked my testbed install somehow.

From what I can tell, if there is only one post in the category WordPress is able to find the correct page 100% of the time. If there are multiple posts in the category, it seems like the most recent post is the only one that will load reliably. This is true for all categories except the default category (Uncategorized or as I have it renamed General). The default category is broken, all of the posts that are members of it end up getting stuck in redirect loops.

[markjaquith]

My fault... had some code in mu-plugins that was messing with redirects. I see the problem exhibited fully, now. Bumping up priority/severity. Can take a look tonight, but if someone wants to take a swing in the meantime, go ahead.

is_category should be FALSE for these requests, because they're is_single requests. And the category portion of the URL is typically ignored when making the query (because you have a unique post slug or ID) — that may have changed in 3.1

[scribu]

I'm looking into this now.

[ryan]

(In [16513]) array_unique() categoryin and categorynot_in to eliminate dupes from multiple runs of parse_tax_query(). Fixes canonical redirects for cat, categoryin, and categorynot_in requests. see #12891 #15487

[automattor]

(In [16515]) Don't do any taxonomy stuff if is_singular. See #15487

[mtekk]

Looks like the last commit by automattor fixed it. Anyone else confirm?

[tar.gz]

I'm currently running 3.1-beta1-16732 and I see this issue reappearing on a site that was fine in WP 3.0.3.

My custom link structure is: /%year%/%category%/%postname%/ (since starting with %category% is not recommended for performance reasons).

[tar.gz]

Note: the previous beta build i was running was [16723], here the permalinks were still working.

Note2: a custom structure such as /%year%/%postname%/ works fine, so it's really the %category% that causes the trouble.

[greuben]

The last patch works but is not returning proper results

[greuben]

need some more testing

[greuben]

whoops...working at wrong file and lines

[mtekk]

Looks like scribu broke it in [16851]

[scribu]

(In [16880]) Don't set query flags in parse_tax_query(). See #15487

[scribu]

Should be fixed now. Please confirm.

[mtekk]

Ok, works for me now, again, closing as fixed