WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#15493 closed defect (bug) (fixed)

Twenty Ten: twentyten_remove_recent_comments_style() throws notice when Recent Comments not in use

Reported by: kawauso Owned by: nacin
Milestone: 3.1 Priority: normal
Severity: trivial Version:
Component: Themes Keywords: has-patch
Focuses: Cc:

Description

twentyten_remove_recent_comments_style() uses $wp_widget_factory->widgets['WP_Widget_Recent_Comments'], but this is not present when the Recent Comments widget is not in use and the user cannot modify widgets, resulting in an undefined index.

Attachments (1)

15493.diff (667 bytes) - added by kawauso 3 years ago.

Download all attachments as: .zip

Change History (6)

kawauso3 years ago

comment:1 kawauso3 years ago

  • Component changed from General to Themes
  • Severity changed from normal to trivial

comment:2 nacin3 years ago

  • Milestone changed from Awaiting Review to 3.1
  • Owner set to nacin
  • Status changed from new to accepted

This widget factory code makes my eyes glaze over. (And I wrote it.) I'm making this a filter.

comment:3 nacin3 years ago

Ran into #14876 while working on this.

comment:4 nacin3 years ago

(In [16521]) Revert [15994] for now, as the default widgets then go through an identity crisis. see #14876, #15493.

comment:5 nacin3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [16522]) Add a simple filter to allow removing the recent comments default widget styles. fixes #15493, see #14876.

Note: See TracTickets for help on using tickets.