Context Navigation

← Previous Ticket
Next Ticket →

#15493 closed defect (bug) (fixed)

Twenty Ten: twentyten_remove_recent_comments_style() throws notice when Recent Comments not in use

Reported by:	kawauso	Owned by:	nacin
Priority:	normal	Milestone:	3.1
Component:	Themes	Version:
Severity:	trivial	Keywords:	has-patch
Cc:		Focuses:

Description

twentyten_remove_recent_comments_style() uses $wp_widget_factory->widgets['WP_Widget_Recent_Comments'], but this is not present when the Recent Comments widget is not in use and the user cannot modify widgets, resulting in an undefined index.

Attachments (1)

15493.diff (667 bytes ) - added by kawauso 16 years ago.

Download all attachments as: .zip

Change History (6)

@kawauso
16 years ago

Attachment 15493.diff added

#1 @kawauso
16 years ago

Component General → Themes
Severity normal → trivial

#2 @nacin
16 years ago

Milestone Awaiting Review → 3.1
Owner set to nacin
Status new → accepted

This widget factory code makes my eyes glaze over. (And I wrote it.) I'm making this a filter.

#3 @nacin
16 years ago

Ran into #14876 while working on this.

#4 @nacin
16 years ago

(In [16521]) Revert [15994] for now, as the default widgets then go through an identity crisis. see #14876, #15493.

#5 @nacin
16 years ago

Resolution → fixed
Status accepted → closed

(In [16522]) Add a simple filter to allow removing the recent comments default widget styles. fixes #15493, see #14876.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#15493 closed defect (bug) (fixed)

Twenty Ten: twentyten_remove_recent_comments_style() throws notice when Recent Comments not in use

Description

Attachments (1)

Change History (6)

@kawauso 16 years ago

#1 @kawauso 16 years ago

#2 @nacin 16 years ago

#3 @nacin 16 years ago

#4 @nacin 16 years ago

#5 @nacin 16 years ago