Use !is_user_logged_in instead of !$user->ID

[Eteq]

The subject line pretty much says all. I'm kind of integrating a user system of my own to allow comments into wordpress posts as if logged in amongst other few minor changes like session sharing. I've managed to do so as a plugin, until I got stuck with this.

The fact that many places in the wordpress code checks for the user id, instead of using the is_user_looged_in renders the purpose of that function useless for plugins.

[johnbillion]

I'll volunteer to patch this one up unless Eteq or someone else wants to.

[SergeyBiryukov]

Any examples? I've found only one instance in wp-includes/capabilities.php:

if ( ! $user || ! $user->ID )
	return false;

[garyc40]

there's a patch for that

[ocean90]

15508.patch​ includes the changes from 15508.diff​ for wp-includes/comment-template.php.

Not sure if we have to change wp-comments-post.php too, since we already have $user->exists() here. I have included it in 15508.2.patch​.

[ocean90]

In 25562:

Replace !$user_ID with !is_user_logged_in(). props garyc40. see #15508.

[ocean90]

There is no difference between $user->exists() and is_user_logged_in() for wp-comments-post.php. If you overwrite is_user_logged_in() you probably overwrite wp_get_current_user() too, so no need to change something here.

Calling as fixed.