WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#15525 closed defect (bug) (fixed)

Use network/update-core.php and redirect to /network/ if it's necessary

Reported by: ocean90 Owned by: ocean90
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: Network Admin Keywords:
Focuses: multisite Cc:

Description

Title is enough.

Attachments (4)

15525.2.patch (6.2 KB) - added by ocean90 5 years ago.
15525.patch (3.4 KB) - added by ocean90 5 years ago.
Refreshed, only /network/update-core.php fix
15525.3.patch (8.3 KB) - added by ocean90 5 years ago.
15525.4.patch (1.1 KB) - added by PeteMall 5 years ago.
Hide tabs on site admin themes page for multisite/

Download all attachments as: .zip

Change History (14)

comment:1 @nacin5 years ago

That looks good.

Thinking we should do an audit for files that should redirect to /network/ when running multisite. Otherwise is_network_admin() would return false and plugins (and potentially core) may get confused.

This file would be one of them. It's a simple is_multisite() && ! is_network_admin() check.

comment:2 @ocean905 years ago

  • Component changed from Upgrade/Install to Network Admin
  • Owner set to ocean90
  • Status changed from new to accepted
  • Summary changed from Use network/update-core.php in Multisite to Use network/update-core.php and redirect to /network/ if it's necessary

@ocean905 years ago

comment:3 @ocean905 years ago

15525.2.patch is a first pass for nacin's point. PeteMall is also working on it, maybe he has a better idea.

@ocean905 years ago

Refreshed, only /network/update-core.php fix

comment:4 @nacin5 years ago

Original patch still looks good. Just need to exit after the wp_redirect calls.

@ocean905 years ago

comment:5 @ocean905 years ago

15525.3.patch includes the redirection, the link change to network/update-core.php and removes the editor links from the site admin menu if it's multisite.

comment:6 @nacin5 years ago

(In [16747]) Link to network/update-core when running multisite. Remove theme/plugin editors from blog menu when running multisite. Redirect to network/* when accessing theme/plugin-install/editor. props ocean90, see #15525.

comment:7 @nacin5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

comment:8 @PeteMall5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Tabs should not be shown on the themes page for multisite installs.

@PeteMall5 years ago

Hide tabs on site admin themes page for multisite/

comment:9 @PeteMall5 years ago

(In [16754]) Hide tabs on site admin themes screen for multisite. See #15525

comment:10 @PeteMall5 years ago

  • Keywords has-patch removed
  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.