WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#15546 closed defect (bug) (fixed)

Bailing too early hides the version number in wp-admin

Reported by: nacin Owned by:
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.0
Component: Multisite Keywords: has-patch commit
Focuses: Cc:

Description

When running multisite, we decline to show the version number in the footer and in the right now box.

In both situations, we should still show the text -- current_user_can('update_core') is designed to whether they also get an update nag, and that should apply to multisite, too.

This is a MU-era vestige I'm strongly inclined to end. (Both functions returned false if not is_site_admin().)

Attachments (2)

15546.diff (779 bytes) - added by nacin 3 years ago.
15546.patch (1.4 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (6)

nacin3 years ago

comment:1 scribu3 years ago

I'm wondering, should non-super-admins ever see the current version at all?

comment:2 nacin3 years ago

  • Milestone changed from 3.1 to Future Release

SergeyBiryukov3 years ago

comment:3 SergeyBiryukov3 years ago

  • Milestone changed from Future Release to 3.3

Refreshed for 3.3. Change logic in update_right_now_message() to only call get_preferred_from_update_core() if current_user_can('update_core').

comment:4 markjaquith3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

More consistent right-now/footer messages related to version and upgrades in multisite. props SergeyBiryukov. fixes #15546

Last edited 3 years ago by markjaquith (previous) (diff)
Note: See TracTickets for help on using tickets.