WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#15547 closed defect (bug) (fixed)

Plugin rows are squished

Reported by: nacin Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

Create a plugin with no description. The row is very squished. You'll then notice that the rows that have full information are missing their share of padding too. I imagine this occurred with the LT refactoring. Let's make it look how it was in 3.0.

Attachments (2)

Screenshot.png (66.5 KB) - added by scribu 3 years ago.
15547.diff (396 bytes) - added by batmoo 3 years ago.
Add in some bottom padding

Download all attachments as: .zip

Change History (9)

comment:1 scribu3 years ago

Context: #15318

scribu3 years ago

comment:2 scribu3 years ago

It looks ok to me. Tested in Firefox and Chrome. See the screenshot.

batmoo3 years ago

Add in some bottom padding

comment:3 batmoo3 years ago

  • Cc batmoo@… added
  • Keywords has-patch added; needs-patch removed
  • Version set to 3.1

Patch brings back the bottom padding. Rows look a bit more roomier now :)

comment:4 nacin3 years ago

I tracked this down to .plugins .second td, .plugins .second th having five pixels of bottom padding in 3.0.

With the second row gone, this should now be .plugins .second.

It looks like that old CSS still exists. Can we kill what is no longer used to construct the second row? (low priority)

If there's a back compat case to be had here (for once, I don't think so), then we just need to make sure that .plugins .second gets 5px bottom padding.

comment:5 nacin3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [16745]) Restore bottom padding in plugin rows. fixes #15547.

comment:6 nacin3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

The action links need this too.

comment:7 nacin3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Never mind. Something was messing up my formatting.

Note: See TracTickets for help on using tickets.