WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#15553 closed defect (bug) (fixed)

Move search results text in site-themes/site-users

Reported by: PeteMall Owned by: PeteMall
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: Administration Keywords: has-patch ui-feedback
Focuses: Cc:

Description (last modified by ocean90)

The search results text is showed next to the <h2> on the list-table screens but this doesn't make sense for the site-themes or site-users page because of the tabs. The text needs to be moved under the tabs... See attached image.

Attachments (5)

site-themes.png (185.1 KB) - added by PeteMall 3 years ago.
15553.diff (1.0 KB) - added by sorich87 3 years ago.
15553.2.diff (607 bytes) - added by sorich87 3 years ago.
Alternative: don't show the search result text at all
15553.3.diff (1.0 KB) - added by PeteMall 3 years ago.
15553.4.diff (1.0 KB) - added by PeteMall 3 years ago.

Download all attachments as: .zip

Change History (15)

PeteMall3 years ago

comment:1 ocean903 years ago

  • Description modified (diff)
  • Summary changed from Move search results text in site-themes to Move search results text in site-themes/site-users

For site-users too.

comment:2 sorich873 years ago

  • Owner set to sorich87
  • Status changed from new to accepted

comment:3 follow-up: scribu3 years ago

I would suggest, like in the case of the normal theme search screen, to just not show the text at all. See [16525]

sorich873 years ago

sorich873 years ago

Alternative: don't show the search result text at all

comment:4 sorich873 years ago

  • Keywords has-patch ui-feedback added; needs-patch removed

comment:5 in reply to: ↑ 3 nacin3 years ago

Replying to scribu:

I would suggest, like in the case of the normal theme search screen, to just not show the text at all. See [16525]

-1 to that approach and to [16525]. That's a usability issue, no?

comment:6 ocean903 years ago

My idea is to display the text next to the search field on all screens.

comment:8 JohnONolan3 years ago

I would argue for not having the text at all - if people need to remember what they searched for they'll usually just look at the search box that they typed in - just like Google.

However I think I remember Jane signing off on Pete's approach in IRC

comment:9 nacin3 years ago

  • Owner changed from sorich87 to PeteMall
  • Status changed from accepted to assigned

PeteMall3 years ago

PeteMall3 years ago

comment:10 PeteMall3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [16961]) Move search results text in site-themes/site-users. Props sorich87, ocean90. Fixes #15553

Note: See TracTickets for help on using tickets.