WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#15556 closed defect (bug) (fixed)

Allow translators to change the dash symbol

Reported by: SergeyBiryukov Owned by: nacin
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.0.1
Component: I18N Keywords: has-patch 3.3-early
Focuses: Cc:

Description

In addition to curly quotes (see #10001), the dash symbol should be localized too.

wptexturize() uses – (en dash) to replace some character sequences. However in Russian — (em dash) is always used instead of that.

Attachments (3)

15556.patch​ (1.4 KB) - added by SergeyBiryukov 3 years ago.
15556.2.patch​ (2.2 KB) - added by SergeyBiryukov 3 years ago.
15556.3.patch​ (2.4 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (12)

SergeyBiryukov — 3 years ago

comment:1 SergeyBiryukov — 3 years ago

  • Keywords has-patch added

comment:2 SergeyBiryukov — 3 years ago

Is it possible to add this into 3.1?

comment:3 nacin — 3 years ago

Would we also not want to offer the em dash for translation?

We'd want $dash to be a static variable here.

Let's do this in early 3.2?

SergeyBiryukov — 3 years ago

comment:4 SergeyBiryukov — 3 years ago

Updated the patch for both en dash and em dash.

Agreed for 3.2-early. Was just hoping :)

comment:5 SergeyBiryukov — 3 years ago

  • Keywords 3.2-early added

comment:6 nacin — 3 years ago

  • Milestone changed from Awaiting Review to Future Release

SergeyBiryukov — 3 years ago

comment:7 SergeyBiryukov — 3 years ago

  • Keywords 3.3-early added; 3.2-early removed

Refreshed for 3.3.

comment:8 SergeyBiryukov — 3 years ago

  • Milestone changed from Future Release to 3.3

comment:9 nacin — 2 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [19187]:

Allow 8212/8211 (em dash and en dash) to be translated in wptexturize(). props SergeyBiryukov, fixes #15556.

Note: See TracTickets for help on using tickets.