WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#15558 closed task (blessed) (fixed)

Re-factor network/site-users.php to use a list table

Reported by: PeteMall Owned by: PeteMall
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: Multisite Keywords: has-patch
Focuses: Cc:

Description

Adapt wp-admin/includes/class-wp-users-list-table.php for the Network Admin Site Users page.

Attachments (8)

15558.diff (7.9 KB) - added by PeteMall 5 years ago.
work in progress
15558.2.diff (12.2 KB) - added by PeteMall 5 years ago.
15558.3.diff (12.1 KB) - added by PeteMall 5 years ago.
Updated cap checks.
15558.screen-options.diff (1.0 KB) - added by duck_ 5 years ago.
15558.hide.posts.col.patch (932 bytes) - added by ocean90 5 years ago.
15558.4.diff (4.5 KB) - added by PeteMall 5 years ago.
Update and error messages.
15558.5.diff (5.2 KB) - added by PeteMall 5 years ago.
Create new user form.
15558.6.diff (606 bytes) - added by JohnONolan 5 years ago.
Amends CSS to be global classes not associated with specific tags.

Download all attachments as: .zip

Change History (25)

@PeteMall5 years ago

work in progress

@PeteMall5 years ago

@PeteMall5 years ago

Updated cap checks.

comment:1 @PeteMall5 years ago

(In [16560]) Adapt user-list-table for network admin site-users. See #15558

comment:2 @PeteMall5 years ago

  • Type changed from defect (bug) to task (blessed)

TODO:

  • Screen Option - Users per page
  • Handle redirection from user-edit.php
  • Contextual help

Patches welcome ;)

@duck_5 years ago

comment:3 @PeteMall5 years ago

(In [16570]) Add screen option in site-users. Props duck_, see #15558

comment:4 @PeteMall5 years ago

(In [16573]) Hide posts column for site-users. Props ocean90, see #15558

@PeteMall5 years ago

Update and error messages.

comment:5 @westi5 years ago

Latest patch looks like a good step in the right direction

comment:6 @PeteMall5 years ago

(In [16582]) Update and error messages for site-users. See #15558.

comment:7 @PeteMall5 years ago

(In [16584]) Exit after wp_redirect(). See #15558

@PeteMall5 years ago

Create new user form.

comment:8 @PeteMall5 years ago

(In [16586]) Create new user form for site-users. See #15558

comment:9 @westi5 years ago

(In [16607]) Make the list of actions that can be performed on a site in the User List in Network admin filterable.
Add classes for all core site status types to the view url.
Move the CSS to a css file rather than including it inline.
See #15558

comment:10 follow-up: @JohnONolan5 years ago

Suggestion:

Instead of changing

tr.site-mature {

to

tr.site-mature, a.site-mature {

Why don't we change it to

.site-mature {

Unless there are other instances of .site-mature within different tags which require different styling then this would be the best way to go. Same for .site-deleted and .site-spammed and .site-archived

comment:11 in reply to: ↑ 10 @westi5 years ago

Replying to JohnONolan:

Suggestion:

Instead of changing

tr.site-mature {

to

tr.site-mature, a.site-mature {

Why don't we change it to

.site-mature {

Unless there are other instances of .site-mature within different tags which require different styling then this would be the best way to go. Same for .site-deleted and .site-spammed and .site-archived

Probably true - I was too lazy to search for other instances at the time I was doing this. :-(

comment:12 @beaulebens5 years ago

User rows are not currently highlighted when a user is set as spam. Changing line 146 to this will fix it:

$alt .= " $col"; 

comment:13 follow-up: @JohnONolan5 years ago

@westi - want me to patch? :)

comment:14 in reply to: ↑ 13 @westi5 years ago

Replying to JohnONolan:

@westi - want me to patch? :)

Please

comment:15 @westi5 years ago

(In [16879]) Fix row hilighting when user is spam. See #15558 props beaulebens.

@JohnONolan5 years ago

Amends CSS to be global classes not associated with specific tags.

comment:16 @JohnONolan5 years ago

  • Keywords has-patch added

comment:17 @ryan5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [16902]) Make classes global. Props JohnONolan. fixes #15558

Note: See TracTickets for help on using tickets.