WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#15573 closed defect (bug) (fixed)

Post Count Links are Bogus When query_var = false

Reported by: miqrogroove Owned by: scribu
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.0.1
Component: Taxonomy Keywords:
Focuses: Cc:

Description

If I call register_taxonomy() with $args = ('query_var' => FALSE) then the links listed in the post count column of the taxonomy editor don't work as expected. The links should not be displayed if they are defective like this.

Attachments (2)

15573.diff (803 bytes) - added by scribu 3 years ago.
Use 'taxonomy' => 'foo', 'term' => 'bar'
15573.2.diff (897 bytes) - added by scribu 3 years ago.
Also check public flag

Download all attachments as: .zip

Change History (9)

comment:1 scribu3 years ago

  • Milestone changed from Awaiting Review to 3.1
  • Owner set to scribu
  • Status changed from new to accepted

comment:2 scribu3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [16578]) Don't link post counts if taxonomy isn't queryable. Fixes #15573

comment:3 follow-up: nacin3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Just because it doesn't have a query var, doesn't make it not queryable. We have taxonomy and term query vars for that. You have to make a separate publicly queryable check.

scribu3 years ago

Use 'taxonomy' => 'foo', 'term' => 'bar'

comment:4 in reply to: ↑ 3 scribu3 years ago

Replying to nacin:

Just because it doesn't have a query var, doesn't make it not queryable. We have taxonomy and term query vars for that.

15573.diff does that.

You have to make a separate publicly queryable check.

The 'public' option reads: @TODO not implemented.

Hm...

scribu3 years ago

Also check public flag

comment:5 scribu3 years ago

The only way the columns would not be linked is with public=false and show_ui=true, which doesn't make much sense, but hey...

comment:6 scribu3 years ago

(In [16579]) Check public flag instead of query_var to decide if counts should be linked. See #15573

comment:7 scribu3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.