Post Count Links are Bogus When query_var = false

[miqrogroove]

If I call register_taxonomy() with $args = ('query_var' => FALSE) then the links listed in the post count column of the taxonomy editor don't work as expected. The links should not be displayed if they are defective like this.

[scribu]

(In [16578]) Don't link post counts if taxonomy isn't queryable. Fixes #15573

[nacin]

Just because it doesn't have a query var, doesn't make it not queryable. We have taxonomy and term query vars for that. You have to make a separate publicly queryable check.

[scribu]

Use 'taxonomy' => 'foo', 'term' => 'bar'

[scribu]

Replying to nacin:

Just because it doesn't have a query var, doesn't make it not queryable. We have taxonomy and term query vars for that.

15573.diff does that.

You have to make a separate publicly queryable check.

The 'public' option reads: @TODO not implemented.

Hm...

[scribu]

Also check public flag

[scribu]

The only way the columns would not be linked is with public=false and show_ui=true, which doesn't make much sense, but hey...

[scribu]

(In [16579]) Check public flag instead of query_var to decide if counts should be linked. See #15573