WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 6 months ago

#15576 closed defect (bug)

Proper l10n of items per page in the screen options — at Version 13

Reported by: SergeyBiryukov Owned by:
Milestone: 4.2 Priority: normal
Severity: normal Version: 3.1
Component: I18N Keywords: has-patch commit
Focuses: Cc:

Description (last modified by SergeyBiryukov)

Sites, Users, Comments, Media items and Plugins have their own translation context on the screen options tab, e.g. “sites per page (screen options)”.

To use the right grammatical case, Posts, Pages, Categories and Tags should have that context too.

Change History (19)

comment:1 @zeo5 years ago

Related #13673

comment:2 @dd325 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

@SergeyBiryukov5 years ago

comment:3 @SergeyBiryukov5 years ago

  • Keywords 3.2-early has-patch added; needs-patch removed

@SergeyBiryukov4 years ago

comment:4 @SergeyBiryukov4 years ago

  • Keywords 3.3-early added; 3.2-early removed

Refreshed for 3.3.

comment:5 @SergeyBiryukov4 years ago

  • Milestone changed from Future Release to 3.3

comment:6 in reply to: ↑ description @SergeyBiryukov4 years ago

Also, for proper translation all of these strings should support single and plural forms.

That part won't be implemented, according to nacin's comment on #13673.

The context, however, is still needed, so this is what the patch does.

comment:7 follow-up: @nacin4 years ago

  • Keywords 3.3-early removed
  • Milestone changed from 3.3 to Awaiting Review

15576.2.patch isn't very backwards compatible. per_page should be implemented like menu_name was -- if it isn't set, it goes forward with the existing "name" argument, rather than defaulting to "Posts"/"Pages".

comment:8 @nacin4 years ago

  • Milestone changed from Awaiting Review to Future Release

@SergeyBiryukov4 years ago

comment:9 in reply to: ↑ 7 @SergeyBiryukov4 years ago

Replying to nacin:

per_page should be implemented like menu_name was -- if it isn't set, it goes forward with the existing "name" argument, rather than defaulting to "Posts"/"Pages".

Thanks, done in 15576.3.patch.

comment:10 @SergeyBiryukov3 years ago

  • Milestone changed from Future Release to 3.5

@SergeyBiryukov3 years ago

@SergeyBiryukov3 years ago

@SergeyBiryukov3 years ago

comment:11 @SergeyBiryukov3 years ago

As an alternative, we could replace "Posts"/"Pages" with "items" string (15576.4.patch), which we already have in options-reading.php:
http://core.trac.wordpress.org/browser/tags/3.4.1/wp-admin/options-reading.php#L111

The use case is essentially the same, so the context might not be needed. 15576.5.patch adds it just in case (and uses the uppercased word for consistency with other screens).

With 15576.6.patch, we could remove 9 strings by making the same change on the other screens (for consistency as well).

comment:12 @nacin3 years ago

  • Milestone changed from 3.5 to Future Release

Moving to "items" across the board is a decent idea. We can talk about it in 3.6.

comment:13 @SergeyBiryukov3 years ago

  • Description modified (diff)

To summarize, "20 Записи" (20 Posts) isn't a valid expression in Russian.

It should be "20 записей", but it's currently impossible to use the proper translation due to the lack of context. I imagine Czech (according to pavelevap's comments on #13673) and other languages with declensions have the same problem here.

Introducing a new post type label just for screen options seems like an overkill, hence the "Items" suggestion.

Last edited 3 years ago by SergeyBiryukov (previous) (diff)
Note: See TracTickets for help on using tickets.