WordPress.org
Get WordPress

Make WordPress Core

Opened 16 years ago

Closed 15 years ago

Last modified 15 years ago

#15581 closed defect (bug) (fixed)

Incomplete Abstraction of wp_insert_category()

Reported by: miqrogroove Owned by: garyc40
Priority: normal Milestone: 3.4
Component: General Version: 3.0
Severity: normal Keywords: has-patch needs-testing 3.2-early
Cc: Focuses:

Description

in wp-admin/includes/taxonomy.php the function wp_insert_category() takes a taxonomy argument, but it still relies on functions category_exists() and cat_is_ancestor_of() which do not work accordingly.

Attachments (3)

garyc40-15581.patch​ (2.5 KB ) - added by garyc40 16 years ago.
there's a patch for that
15581.diff​ (3.1 KB ) - added by ryan 15 years ago.
Refreshed
15581-unit.diff​ (1.8 KB ) - added by ryan 15 years ago.
Quick unit tests

Download all attachments as: .zip

Change History (8)

#1 @nacin
16 years ago

  • Keywords needs-patch added
  • Milestone Awaiting Review → Future Release

Looks like it'll work fine for non-hierarchical taxonomies or top-level terms in the meantime. Nice catch.

#2 @garyc40
16 years ago

  • Owner set to garyc40
  • Status new → assigned

@garyc40
16 years ago

there's a patch for that

#3 @garyc40
16 years ago

  • Keywords has-patch needs-testing 3.2-early added; needs-patch removed

@ryan
15 years ago

Refreshed

@ryan
15 years ago

Quick unit tests

#4 @ryan
15 years ago

  • Resolution → fixed
  • Status assigned → closed

In [19678]:

Introduce term_is_ancestor_of(). Finish taxonomy support for wp_insert_category(). Props garyc40. fixes #15581

Note: See TracTickets for help on using tickets.