WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 14 months ago

#15585 closed defect (bug) (fixed)

"LGPL License" should just be "LGPL"

Reported by: lloydbudd Owned by: markjaquith
Milestone: 3.6 Priority: lowest
Severity: trivial Version: 3.1
Component: General Keywords: 3.2-early has-patch
Focuses: Cc:

Description (last modified by lloydbudd)

The GNU Lesser General Public License License?

$ ack -l "LGPL License"
wp-admin/includes/class-ftp-pure.php
wp-admin/includes/class-ftp-sockets.php
wp-admin/includes/class-ftp.php
wp-includes/js/tinymce/plugins/wpdialogs/editor_plugin.dev.js
wp-includes/js/tinymce/plugins/wpdialogs/js/popup.dev.js
wp-includes/js/tinymce/themes/advanced/js/charmap.js
wp-includes/js/tinymce/utils/editable_selects.js
wp-includes/js/tinymce/utils/form_utils.js
wp-includes/js/tinymce/utils/mctabs.js
wp-includes/js/tinymce/utils/validate.js

Attachments (2)

15585.patch (2.8 KB) - added by jakub.tyrcha 3 years ago.
15585.diff (4.4 KB) - added by wonderboymusic 16 months ago.

Download all attachments as: .zip

Change History (11)

comment:1 lloydbudd3 years ago

  • Description modified (diff)

comment:2 jacobsantos3 years ago

The TinyMCE files should not be modified by WordPress. This needs to be sent upstream because they will simply be overridden when TinyMCE is upgraded.

The Class FTP files are also third-party files, but I'm not sure if they are maintained and where the original files are. It would be better to send the patch upstream as well, but might suffice to simply fix it in WordPress.

comment:3 hakre3 years ago

Related: #14726

comment:4 nacin3 years ago

  • Keywords 3.2-early added
  • Milestone changed from Awaiting Review to Future Release

jakub.tyrcha3 years ago

comment:5 jakub.tyrcha3 years ago

PemFTP is not maintained at all, last commits date to 2008. The patch improves the wording in the FTP class files and the editor plugin for TinyMCE, which, I think, is maintained by WP?

comment:6 SergeyBiryukov3 years ago

  • Keywords has-patch added

wonderboymusic16 months ago

comment:7 wonderboymusic16 months ago

  • Milestone changed from Future Release to 3.6

Bringing back from the basement of 3.2-early - refreshed patch. FTP files are DocBlock'd by WordPress, as are the WP TinyMCE plugins, updated only those so they aren't clobbered by upstream updates.

comment:8 aaronholbrook15 months ago

Tested on trunk, looks good.

comment:9 markjaquith14 months ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In 23425:

"LGPL License" is redundant.

props wonderboymusic, jakub.tyrcha. fixes #15585

Note: See TracTickets for help on using tickets.