Make WordPress Core

Opened 16 years ago

Closed 14 years ago

#15585 closed defect (bug) (fixed)

"LGPL License" should just be "LGPL"

Reported by: lloydbudd Owned by: markjaquith
Priority: lowest Milestone: 3.6
Component: General Version: 3.1
Severity: trivial Keywords: 3.2-early has-patch
Cc: Focuses:

Description (last modified by lloydbudd)

The GNU Lesser General Public License License?

$ ack -l "LGPL License"
wp-admin/includes/class-ftp-pure.php
wp-admin/includes/class-ftp-sockets.php
wp-admin/includes/class-ftp.php
wp-includes/js/tinymce/plugins/wpdialogs/editor_plugin.dev.js
wp-includes/js/tinymce/plugins/wpdialogs/js/popup.dev.js
wp-includes/js/tinymce/themes/advanced/js/charmap.js
wp-includes/js/tinymce/utils/editable_selects.js
wp-includes/js/tinymce/utils/form_utils.js
wp-includes/js/tinymce/utils/mctabs.js
wp-includes/js/tinymce/utils/validate.js

Attachments (2)

15585.patch (2.8 KB ) - added by jakub.tyrcha 15 years ago.
15585.diff (4.4 KB ) - added by wonderboymusic 14 years ago.

Download all attachments as: .zip

Change History (11)

#1 @lloydbudd
16 years ago

  • Description modified (diff)

#2 @jacobsantos
16 years ago

The TinyMCE files should not be modified by WordPress. This needs to be sent upstream because they will simply be overridden when TinyMCE is upgraded.

The Class FTP files are also third-party files, but I'm not sure if they are maintained and where the original files are. It would be better to send the patch upstream as well, but might suffice to simply fix it in WordPress.

#3 @hakre
16 years ago

Related: #14726

#4 @nacin
16 years ago

  • Keywords 3.2-early added
  • Milestone Awaiting ReviewFuture Release

@jakub.tyrcha
15 years ago

#5 @jakub.tyrcha
15 years ago

PemFTP is not maintained at all, last commits date to 2008. The patch improves the wording in the FTP class files and the editor plugin for TinyMCE, which, I think, is maintained by WP?

#6 @SergeyBiryukov
15 years ago

  • Keywords has-patch added

#7 @wonderboymusic
14 years ago

  • Milestone Future Release3.6

Bringing back from the basement of 3.2-early - refreshed patch. FTP files are DocBlock'd by WordPress, as are the WP TinyMCE plugins, updated only those so they aren't clobbered by upstream updates.

#8 @aaronholbrook
14 years ago

Tested on trunk, looks good.

#9 @markjaquith
14 years ago

  • Owner set to markjaquith
  • Resolutionfixed
  • Status newclosed

In 23425:

"LGPL License" is redundant.

props wonderboymusic, jakub.tyrcha. fixes #15585

Note: See TracTickets for help on using tickets.