WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 8 months ago

#15588 closed enhancement (wontfix)

GoogleSpell.php preg_replace eval removed

Reported by: underground-stockholm Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.0.1
Component: TinyMCE Keywords: has-patch upstream 3.2-early needs-refresh
Focuses: Cc:

Description

Hello,

I have found and fixed one more of the preg_replace /e eval constructs, that aren't allowed in WordPress according to the coding standards.

-- Frank | Underground Stockholm

Attachments (1)

googlespell.preg-eval-remove.diff (1005 bytes) - added by underground-stockholm 3 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 jacobsantos3 years ago

  • Type changed from defect (bug) to enhancement

This needs to be sent upstream to TinyMCE.

comment:2 westi3 years ago

  • Cc nacin westi added
  • Component changed from General to TinyMCE
  • Keywords upstream 3.2-early added
  • Milestone changed from Awaiting Review to Future Release

comment:3 ocean903 years ago

  • Cc azaozz added

comment:4 wonderboymusic15 months ago

  • Keywords needs-refresh added; needs-testing removed

Is this file even used? It also has mb_substr() - Multibyte String is a non-default extension in PHP, even now. GoogleSpell is named in a config here:

wp-includes/js/tinymce/plugins/spellchecker/config.php


comment:5 dd328 months ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

The Google Spellcheck API is no longer available. The TinyMCE plugin is still included, but disabled, it'll be going away soon entirely #24789

Note: See TracTickets for help on using tickets.