Bulk spam/unspam of a blog leads to inconsistencies when object cache in use

[westi]

If you use the bulk spam/unspam actions in the Network Admin when you have a persistent object cache enabled then you can end up with the database thinking a blog is spam but the cache thinking it isn't.

This is because we call update_blog_status with 0 as the fourth argument explicit asking it not to refresh the cache(s).

It appears to have always been like this so I'm not sure how this ever worked reliably.

[ryan]

update_user_status() and update_blog_option() also have refresh arguments. Perhaps the point is to avoid multiple get_blog_details() calls due to repeated refresh_blog_details() calls. Separating the cache deletes into a clean_blog_cache() function that is always called would keep the cache consistent while possibly avoiding extra get_blog_details() calls down the line. Or maybe not. These arguments should likely be deprecated and ignored.

[westi]

Yeah they seem quite dangerous as is because the caches don't get cleared and everything is inconsistent.

I wouldn't expect them to get called often enough for cache clearing to be an issue - usually Super Admin tasks anyway.

[ryan]

[16673]

[nacin]

(In [17287]) Don't use deprecated arguments. props PeteMall, see #15605.

[PeteMall]

We are using the deprecated arguments in a couple of other places. attachment:15605.2.diff​

[ryan]

(In [17360]) Don't pass deprecated arg to update_blog_status(). Props PeteMall. fixes #15605