WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 7 years ago

#15605 closed defect (bug) (fixed)

Bulk spam/unspam of a blog leads to inconsistencies when object cache in use

Reported by: westi Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.0
Component: Network Admin Keywords: has-patch
Focuses: multisite Cc:

Description

If you use the bulk spam/unspam actions in the Network Admin when you have a persistent object cache enabled then you can end up with the database thinking a blog is spam but the cache thinking it isn't.

This is because we call update_blog_status with 0 as the fourth argument explicit asking it not to refresh the cache(s).

It appears to have always been like this so I'm not sure how this ever worked reliably.

Attachments (2)

15605.diff (2.6 KB) - added by ryan 8 years ago.
15605.2.diff (635 bytes) - added by PeteMall 7 years ago.

Download all attachments as: .zip

Change History (10)

#1 @ryan
8 years ago

update_user_status() and update_blog_option() also have refresh arguments. Perhaps the point is to avoid multiple get_blog_details() calls due to repeated refresh_blog_details() calls. Separating the cache deletes into a clean_blog_cache() function that is always called would keep the cache consistent while possibly avoiding extra get_blog_details() calls down the line. Or maybe not. These arguments should likely be deprecated and ignored.

#2 @westi
8 years ago

Yeah they seem quite dangerous as is because the caches don't get cleared and everything is inconsistent.

I wouldn't expect them to get called often enough for cache clearing to be an issue - usually Super Admin tasks anyway.

@ryan
8 years ago

#3 @ryan
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

#4 @nacin
7 years ago

(In [17287]) Don't use deprecated arguments. props PeteMall, see #15605.

@PeteMall
7 years ago

#5 @PeteMall
7 years ago

  • Priority changed from high to normal
  • Severity changed from major to normal

We are using the deprecated arguments in a couple of other places. attachment:15605.2.diff

#6 @PeteMall
7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#7 @garyc40
7 years ago

  • Keywords has-patch added

#8 @ryan
7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [17360]) Don't pass deprecated arg to update_blog_status(). Props PeteMall. fixes #15605

Note: See TracTickets for help on using tickets.