WordPress.org
Get WordPress

Make WordPress Core

Opened 20 years ago

Closed 20 years ago

Last modified 18 years ago

#1561 closed defect (bug) (fixed)

General capabilities.php bugs.

Reported by: ringmaster's profile ringmaster Owned by: markjaquith's profile markjaquith
Milestone: Priority: normal
Severity: normal Version: 1.6
Component: Security Keywords: bg|has-patch bg|commit
Focuses: Cc:

Description

Bad Owen, introducing bugs into WordPress...

The is_role() method on WP_Roles doens't actually check for roles.

The filter used to get roles from the user's caps is broken because it filtered the cap values, not the cap keys, which is where the role names are stored.

The resulting filtered list becomes value-centric, not key-centric, cascading some changes.

Patch attached.

Attachments (1)

capabilities.php.diff​ (1.1 KB) - added by ringmaster 20 years ago.
patch for mentioned issues

Download all attachments as: .zip

Change History (4)

@ringmaster
20 years ago

patch for mentioned issues

#1 @markjaquith
20 years ago

  • Keywords bg|has-patch bg|commit added
  • Milestone set to 1.6
  • Owner changed from anonymous to markjaquith
  • Status changed from new to assigned

I'm trusting that Owen knows what he's talking about. ;-)

#2 @ryan
20 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [2793]) Capabilities fixes from the O man. fixes #1561

#3 @(none)
18 years ago

  • Milestone 2.0 deleted

Milestone 2.0 deleted

Note: See TracTickets for help on using tickets.