WordPress.org
Get WordPress

Make WordPress Core

Opened 21 years ago

Closed 21 years ago

Last modified 20 years ago

#1561 closed defect (bug) (fixed)

General capabilities.php bugs.

Reported by: ringmaster Owned by: markjaquith
Priority: normal Milestone:
Component: Security Version: 1.6
Severity: normal Keywords: bg|has-patch bg|commit
Cc: Focuses:

Description

Bad Owen, introducing bugs into WordPress...

The is_role() method on WP_Roles doens't actually check for roles.

The filter used to get roles from the user's caps is broken because it filtered the cap values, not the cap keys, which is where the role names are stored.

The resulting filtered list becomes value-centric, not key-centric, cascading some changes.

Patch attached.

Attachments (1)

capabilities.php.diff​ (1.1 KB ) - added by ringmaster 21 years ago.
patch for mentioned issues

Download all attachments as: .zip

Change History (4)

@ringmaster
21 years ago

patch for mentioned issues

#1 @markjaquith
21 years ago

  • Keywords bg|has-patch bg|commit added
  • Milestone → 1.6
  • Owner changed from anonymous to markjaquith
  • Status new → assigned

I'm trusting that Owen knows what he's talking about. ;-)

#2 @ryan
21 years ago

  • Resolution → fixed
  • Status assigned → closed

(In [2793]) Capabilities fixes from the O man. fixes #1561

#3 @(none)
20 years ago

  • Milestone 2.0

Milestone 2.0 deleted

Note: See TracTickets for help on using tickets.