Opened 14 years ago
Closed 9 years ago
#15610 closed defect (bug) (fixed)
Comments on attachments don't appear in site-wide comments RSS feed
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.5 | Priority: | normal |
Severity: | minor | Version: | 3.1 |
Component: | Feeds | Keywords: | has-patch has-unit-tests |
Focuses: | Cc: |
Description
Tested against r16950.
Comments that are entered against an attachment do not appear in the site-wide comments RSS feed (e.g., http://sitename.com/comments/feed/).
To test:
- Add an attachment of any kind (usually image), then View the attachment.
- Post a comment on the attachment page.
- Check the site's comments RSS feed - the comment will not appear.
Attachments (1)
Change History (6)
#4
@
9 years ago
- Keywords has-unit-tests added; dev-feedback removed
- Milestone changed from Future Release to 4.5
- Owner set to stevenkword
- Status changed from new to assigned
Patch still applies cleanly and the unit tests pass. However, I think I'd rather see this test in the "feed" group. Otherwise, this looks ready for commit to me.
Note: See
TracTickets for help on using
tickets.
15610.patch adds a test and changes the query for comments to include comments on attachments. I wonder if there needs to be any check on the post status for the attachment's parent post.