WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 4 years ago

#15610 closed defect (bug) (fixed)

Comments on attachments don't appear in site-wide comments RSS feed

Reported by: markel Owned by: stevenkword
Milestone: 4.5 Priority: normal
Severity: minor Version: 3.1
Component: Feeds Keywords: has-patch has-unit-tests
Focuses: Cc:
PR Number:

Description

Tested against r16950.

Comments that are entered against an attachment do not appear in the site-wide comments RSS feed (e.g., http://sitename.com/comments/feed/).

To test:

  1. Add an attachment of any kind (usually image), then View the attachment.
  2. Post a comment on the attachment page.
  3. Check the site's comments RSS feed - the comment will not appear.

Attachments (1)

15610.patch (1.7 KB) - added by jbrinley 5 years ago.

Download all attachments as: .zip

Change History (6)

#1 @nacin
9 years ago

  • Milestone changed from Awaiting Review to Future Release

#2 @chriscct7
5 years ago

  • Keywords needs-patch added

@jbrinley
5 years ago

#3 @jbrinley
5 years ago

  • Keywords has-patch dev-feedback added; needs-patch removed

15610.patch adds a test and changes the query for comments to include comments on attachments. I wonder if there needs to be any check on the post status for the attachment's parent post.

#4 @stevenkword
4 years ago

  • Keywords has-unit-tests added; dev-feedback removed
  • Milestone changed from Future Release to 4.5
  • Owner set to stevenkword
  • Status changed from new to assigned

Patch still applies cleanly and the unit tests pass. However, I think I'd rather see this test in the "feed" group. Otherwise, this looks ready for commit to me.

#5 @rachelbaker
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 36138:

Feeds: Comments on attachments display in the site-wide comments RSS feed.

Individual attachment pages already have their own RSS comment feed, and would be expected to be included in the site-wide comments RSS feed.

Props jbrinley.
Fixes #15610

Note: See TracTickets for help on using tickets.