Left admin menu slides open, hides closed

[johnjamesjacoby]

Noticed this a few weeks ago and figured it was probably temporary.

When you roll-open a top level admin menu, it animates open per normal. When you click to close it, it simply hides without any slide-up/close animation.

Since we have the admin bar and the admin menu, I should add that I'm talking about the left side, traditional admin navigation and not the new top admin bar.

Admin menu is the right name. Admin bar is the bar on the top.

Bug confirmed. It works in 3.0.1.

Just cc-ing myself here because I'd like to follow this for learning purposes. If that's not kosher, please accept my humble apologies.

adding a delay for smooth slide

I think there's a problem with that patch. "dispaly" should be "display". Even with that change, though, this doesn't affect the behavior for me.

fixed the typo

Replying to travisnorthcutt:

I think there's a problem with that patch. "dispaly" should be "display". Even with that change, though, this doesn't affect the behavior for me.

Make the slideToggle a little slower to see the effect.

var id = el.slideToggle(500, function() {
            el.delay(500).animate( {'display': ''}, 500);
		}).parent().toggleClass( 'wp-menu-open' ).attr('id');

The real question is why this was working in 3.0.x. The reason it shouldn't have worked is that the jQuery chained methods get executed before the callback called when the animation is complete. That means that the "wp-menu-open" class should be toggled in the callback, once the sliding animation is complete.

The best answer I have is that with every release, jQuery gets twice as fast. 3.0.x uses jQuery 1.4.2, and 3.1, 1.4.4. Folks, that's 4x as fast. I tried this with the trunk version of jQuery, and it was so fast that the sliding submenu actually went back in time.

So clearly we need the class toggle after the animation is complete, as in toggle-class-in-callback.15615.diff.

Replying to greuben:

Make the slideToggle a little slower to see the effect.

FWIW, this has no effect for me. I may be doing something wrong, though (in fact that would be my first suspicion).

(In [16813]) Fix closing admin menu animation. props filosofo, fixes #15615.

(In [16874]) Fix admin menu save state. props greuben, fixes #15767, see #15615.