Network setup page displays bad code after activation

[wpdavis]

Currently, the network setup page at wp-admin/network/setup.php returns rewrite rules and code for wp-config that doesn't work if accessed after the network is set up. The attached patch moves the $base definition inside the check to see if $_POST is set, else uses the $base that's set in the wp-config.

[wpdavis]

Probably could have been (a lot) clearer above: Problem with the rewrite rules etc. that are returned are that the RewriteBase, among other things, are set to /wp-admin/.

[nacin]

Do we need $base outside of the conditional?

[wpdavis]

@nacin: As far as I can tell, no. All the instances on the page are either handled by the conditional if multisite the multisite hasn't been put in the config file yet or using the $base that's set in wp-config. If post is set it generates $base, if not than it checks to see if multisite is set up and uses the global $base, and if ms isn't set up than you get a form.

[ryan]

[16672]

[scribu]

This now causes problems before the network is setup, in wp-admin/network.php

The $base variable is null in network_step2().

[scribu]

15620.diff​ re-generates $base if it is null.

[nacin]

(In [17323]) Set base if we return to network step 2. props scribu, fixes #15620.