WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#15621 closed defect (bug) (fixed)

Media upload links can be clicked before Lightbox JS is ready.

Reported by: markjaquith Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: Administration Keywords:
Focuses: Cc:

Description

The media upload links can be clicked before the Lightbox JS is ready. This results in the iframe content taking over the whole window (as the browser just follows the link). This issue is exacerbated when a site or an Internet connection is slow, as the window between display and JS "readiness" is larger.

Quick solution: onclick="return false;" which is removed when we're ready to go.

Long term solution: we should queue clicks of JS-powered actions and then fire them off when we're loaded.

Change History (3)

comment:1 markjaquith4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [16646]) Prevent media upload links from being clicked before lightbox is ready to handle them. fixes #15621

comment:2 markjaquith4 years ago

(In [16668]) Doh. [16646] and [16650] were made against the wrong branch. Revert. see #13709. see #15621

comment:3 markjaquith4 years ago

(In [16669]) Prevent media upload links from being clicked before lightbox is ready to handle them. fixes #15621

Note: See TracTickets for help on using tickets.