WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#15632 closed defect (bug) (fixed)

Theme license tags

Reported by: pross Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: Themes Keywords:
Focuses: Cc:

Description

As per http://make.wordpress.org/themes/guidelines/changes-wp-3-1/ theme license tags are being intoduced with 3.1

Here is a small patch for twenty-ten

Attachments (2)

license1.patch (627 bytes) - added by pross 3 years ago.
license2.patch (617 bytes) - added by pross 3 years ago.

Download all attachments as: .zip

Change History (12)

pross3 years ago

comment:1 follow-up: nacin3 years ago

Is this really necessary? Twenty Ten is included in the download, so is the license.

Also, "or newer" should not be specified. Nor "v2" per previous tickets.

comment:2 pross3 years ago

I (we) think it is necessary as a lot of themes use the default theme as a base to write their own themes.

pross3 years ago

comment:3 Frumph3 years ago

@nacin Necessary no, having the main WordPress theme written out in the manner the theme review team is requesting would benefit for themes being made to follow the same suit.

Also Pross/Cais are working with Otto to get more info passed to the theme page including changelog and the readme much like plugins which might in the future include the License.

So representing WordPress's theme methodology it would benefit everyone if the main theme that is distributed adhered to the guidelines as well.

(+1)

comment:4 in reply to: ↑ 1 cais3 years ago

Replying to nacin:

Is this really necessary? Twenty Ten is included in the download, so is the license.

Twenty Ten may be included with the download but it is also available separately from the repository and should meet the Theme Review guidelines in an exemplary fashion.

Also, "or newer" should not be specified. Nor "v2" per previous tickets.

In respect to the License URI, I would think it should be pointing to the one included with the "core" download.

comment:5 chipbennett3 years ago

Please apply the fix.

  1. It doesn't negatively impact the Theme
  2. It helps move to a standard practice that will benefit Theme developers and end users alike
  3. It will help reduce the number of "but TwentyTen doesn't..." arguments in Theme Review comments.
  4. It will help facilitate eventually displaying license information on the Extend listing page

Regarding License URI:

  • If bundling license.txt:
    License URI: license.txt
    
  • If pointing to an external URL (e.g.):
    License URI: http://www.gnu.org/licenses/gpl.html
    
  • If pointing to WordPress' license, I suggest:
    ../../../license.txt
    


Since WordPress' license.txt is in {root}, and the Theme files are in {root}/wp-content/themes/theme-slug

(I'm sure someone has a better suggestion, though.)

comment:6 follow-up: chipbennett3 years ago

Also, I would suggest linking to GPL for License URI, rather than GPLv2.0, if linking to GNU, rather than referencing WordPress core's license.

comment:7 in reply to: ↑ 6 pross3 years ago

Replying to chipbennett:

Also, I would suggest linking to GPL for License URI, rather than GPLv2.0, if linking to GNU, rather than referencing WordPress core's license.

I linked to v2 as thats the version included in the themes root.
The following would have sufficed too:

Licence URI: license.txt


comment:8 nacin3 years ago

  • Milestone changed from Awaiting Review to 3.1

comment:9 chipbennett3 years ago

@nacin thanks! You're the man!

comment:10 markjaquith3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [16883]) Mark Twenty Ten as GPL per new theme directory guidelines. props pross. fixes #15632

Note: See TracTickets for help on using tickets.