Opened 15 years ago
Closed 15 years ago
#15632 closed defect (bug) (fixed)
Theme license tags
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | 3.1 | Priority: | normal |
| Severity: | normal | Version: | 3.1 |
| Component: | Themes | Keywords: | |
| Focuses: | Cc: |
Description
As per http://make.wordpress.org/themes/guidelines/changes-wp-3-1/ theme license tags are being intoduced with 3.1
Here is a small patch for twenty-ten
Attachments (2)
Change History (12)
#2
@
15 years ago
I (we) think it is necessary as a lot of themes use the default theme as a base to write their own themes.
#3
@
15 years ago
@nacin Necessary no, having the main WordPress theme written out in the manner the theme review team is requesting would benefit for themes being made to follow the same suit.
Also Pross/Cais are working with Otto to get more info passed to the theme page including changelog and the readme much like plugins which might in the future include the License.
So representing WordPress's theme methodology it would benefit everyone if the main theme that is distributed adhered to the guidelines as well.
(+1)
#4
in reply to:
↑ 1
@
15 years ago
Replying to nacin:
Is this really necessary? Twenty Ten is included in the download, so is the license.
Twenty Ten may be included with the download but it is also available separately from the repository and should meet the Theme Review guidelines in an exemplary fashion.
Also, "or newer" should not be specified. Nor "v2" per previous tickets.
In respect to the License URI, I would think it should be pointing to the one included with the "core" download.
#5
@
15 years ago
Please apply the fix.
- It doesn't negatively impact the Theme
- It helps move to a standard practice that will benefit Theme developers and end users alike
- It will help reduce the number of "but TwentyTen doesn't..." arguments in Theme Review comments.
- It will help facilitate eventually displaying license information on the Extend listing page
Regarding License URI:
- If bundling license.txt:
License URI: license.txt
- If pointing to an external URL (e.g.):
License URI: http://www.gnu.org/licenses/gpl.html
- If pointing to WordPress' license, I suggest:
../../../license.txt
Since WordPress' license.txt is in {root}, and the Theme files are in {root}/wp-content/themes/theme-slug
(I'm sure someone has a better suggestion, though.)
#7
in reply to:
↑ 6
@
15 years ago
Replying to chipbennett:
Also, I would suggest linking to GPL for License URI, rather than GPLv2.0, if linking to GNU, rather than referencing WordPress core's license.
I linked to v2 as thats the version included in the themes root.
The following would have sufficed too:
Licence URI: license.txt
Is this really necessary? Twenty Ten is included in the download, so is the license.
Also, "or newer" should not be specified. Nor "v2" per previous tickets.