WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#15654 closed defect (bug) (fixed)

Admin bar menu widths

Reported by: johnbillion Owned by: koopersmith
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: Administration Keywords:
Focuses: Cc:

Description

r16301 added a fixed width of 160px to admin bar menus.

My User Switching plugin adds a menu item with the title "Switch back to [display_name] ([user_login])".

The fixed width menu is too narrow for this title in 99% of cases and the text gets cut off.

Can we give menu items a min-width instead of a width?

Attachments (2)

15654.diff (1.8 KB) - added by koopersmith 3 years ago.
15654.fix.opera.the.new.ie6.patch (483 bytes) - added by ocean90 3 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 filosofo3 years ago

A better-looking solution might be to allow multiple-line elements. See #15611

comment:2 nacin3 years ago

  • Milestone changed from Awaiting Review to 3.1
  • Owner set to koopersmith
  • Status changed from new to assigned

Going to move the width to a min-width.

koopersmith3 years ago

comment:3 koopersmith3 years ago

  • Keywords has-patch added

comment:4 westi3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [17295]) Switch to using min-width so long titles can be displayed instead of using elipsis. Fixes #15654 props koopersmith.

comment:5 ocean903 years ago

Version 0, edited 3 years ago by ocean90 (next)

comment:6 ocean903 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

15654.fix.opera.the.new.ie6.patch tested in Chrome, Firefox, Safari and IE7/8/9. No problems.

comment:7 nacin3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [17317]) Remove cruft overflow:hidden from the admin bar items. props ocean90, fixes #15654.

comment:8 follow-up: johnbillion3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Version set to 3.3

This has regressed with changes made as part of #18197.

comment:9 johnbillion3 years ago

  • Keywords has-patch removed

comment:10 in reply to: ↑ 8 westi3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Version changed from 3.3 to 3.1

Replying to johnbillion:

This has regressed with changes made as part of #18197.

Please open a new ticket for the regression as this was fixed in a previous release.

Note: See TracTickets for help on using tickets.