WordPress.org
Get WordPress

Make WordPress Core

Opened 14 years ago

Closed 14 years ago

#15658 closed defect (bug) (fixed)

Plugin "Search Results" tab looking weird

Reported by: batmoo's profile batmoo Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: UI Keywords: has-patch dev-feedback
Focuses: Cc:

Description

The Search Results tab for plugin searches is given a generic class ("search"), inherits some styles and ends up looking weird.

Screenshot attached.

Attachments (3)

search_results_tab.png​ (9.8 KB) - added by batmoo 14 years ago.
15658_unique_classname.diff​ (657 bytes) - added by batmoo 14 years ago.
prefixes classnames for tabs with 'plugin-'
15658_unique_classname_v2.diff​ (1.3 KB) - added by batmoo 14 years ago.
Fixes theme install as well

Download all attachments as: .zip

Change History (8)

@batmoo
14 years ago

@batmoo
14 years ago

prefixes classnames for tabs with 'plugin-'

#1 @batmoo
14 years ago

  • Component changed from General to UI
  • Keywords has-patch dev-feedback added

Patch attempts to make the class name for the tabs a bit more unique by prefixing 'plugin-'. I didn't notice any adverse side-effects from this.

The alternate approach, of course, would be to override the CSS for the affected tab, but that might not be the nicest approach.

#2 @scribu
14 years ago

  • Milestone changed from Awaiting Review to 3.1

#3 @scribu
14 years ago

The same happens for theme search results, so we should fix that too.

@batmoo
14 years ago

Fixes theme install as well

#4 @batmoo
14 years ago

New patch fixes theme install as well.

#5 @scribu
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [16710]) Use more specific view classes in plugin & theme install screens. Props batmoo. Fixes #15658

Note: See TracTickets for help on using tickets.