Add additional image sizes to thickbox

[alexkoti]

Automatically add additional image sizes to thickbox, and provide a hook to filter sizes, in wp-admin/includes/media.php

function image_size_input_fields( $post, $check = '' ) {

		// get a list of the actual pixel dimensions of each possible intermediate version of this image
		$size_names = array('thumbnail' => __('Thumbnail'), 'medium' => __('Medium'), 'large' => __('Large'), 'full' => __('Full Size'));
		
		global $_wp_additional_image_sizes;
		foreach($_wp_additional_image_sizes as $size_name => $size_name_attr){
			$size_names[$size_name] = __($size_name_attr['label']);
		}
		$size_names = apply_filters('image_size_names', $size_names);

		if ( empty($check) )
			$check = get_user_setting('imgsize', 'medium');

Add $label to add_image_size() and set_post_thumbnail_size(), in wp-includes/media.php

/**
 * Registers a new image size
 */
function add_image_size( $name, $width = 0, $height = 0, $crop = FALSE, $label = FALSE ) {
	global $_wp_additional_image_sizes;
	if( empty($label) )
		$label = $name;
	$_wp_additional_image_sizes[$name] = array( 'width' => absint( $width ), 'height' => absint( $height ), 'crop' => !!$crop, 'label' => $label );
}

/**
 * Registers an image size for the post thumbnail
 */
function set_post_thumbnail_size( $width = 0, $height = 0, $crop = FALSE, $label = FALSE ) {
	add_image_size( 'post-thumbnail', $width, $height, $crop, $label );
}

[nacin]

I don't see what this is doing.

Use case? Example? What's this an enhancement of?

Please provide a patch.

[alexkoti]

Additional image sizes listed in insert box.

[alexkoti]

The functions I pasted alredy patched. Sorry, I am beginner in Trac tools and I dont know how to post diffs.

I added image showing two extras image sizes, labeled 'Custom Image Size Name' and 'Another Image Size'. The labels are added in two functions of 'wp-includes/media.php'

The hook 'image_size_names' filter these sizes before show in page.

[nacin]

Makes perfect sense now, especially after reading this tweet: ​http://twitter.com/bradleypotter/status/10943590733717504.

Sorry, I must have been tired earlier, because it made no sense then. :)

You can learn how to submit patches at ​http://core.trac.wordpress.org/#HowToSubmitPatches.

[garyc40]

based on alexkoti's suggested changes

[SergeyBiryukov]

A filter was added in [18802] (for #18520).

[markoheijnen]

Since all the changes of 3.5 this patch isn't valid anymore. Not sure if we can close this ticket in favor of #22100.

[SergeyBiryukov]

Duplicate of #24019.

[SergeyBiryukov]

Not an exact duplicate, as noted in ticket:24019:2.

[SergeyBiryukov]

The Thickbox dialog was removed in #21390.

Let's continue with #24168, as it specifically refers to the new media modal.