WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#15672 closed defect (bug) (fixed)

Sanity text in the theme editor when you have a child theme

Reported by: nacin Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version:
Component: Themes Keywords:
Focuses: Cc:
PR Number:

Description

When editing a child theme, there's no way to know whether you're editing a parent theme file or a child theme file. This could be disastrous, as you could later lose your changes on an update of Twenty Ten when you thought you were doing everything right.

A little warning just above the Save Changes button should be enough as a sanity check until we can more thoroughly overhaul the theme editor in potentially 3.2.

See also #15671, which was a prerequisite to this ticket.

Change History (8)

#1 @nacin
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [16712]) Sanity text in the theme editor when you have a child theme. fixes #15672.

#2 @nacin
9 years ago

(In [16714]) Don't even show parent theme files when viewing the child theme. see #15672.

#3 @nacin
9 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

After talking with Jane some more, I've made a few more minor improvements.

Following up with one last color change.

#4 @nacin
9 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [16716]) Don't use orange as an on state. Also, restore zero margin on the filename header. fixes #15672.

#5 @nacin
9 years ago

(In [16717]) Add 'Visual Editor RTL Stylesheet' to the list of theme file descriptions. see #15672.

#6 @nacin
9 years ago

(In [16718]) Always land on style.css by default, rather than whichever stylesheet came first in the directory scan. Prevents useless trips to editor-style-rtl.css and the like. see #15672.

#7 @nacin
9 years ago

Ok, done :-)

#8 @nacin
9 years ago

[16715] missed the ticket.

Note: See TracTickets for help on using tickets.